From 969473a1a9b72ec9a2d6b8dc651b730e2aed49b3 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Wed, 29 Jun 2022 11:40:41 +0200 Subject: [PATCH] Bug 30982: Try allow-owner --- Koha/REST/V1/BackgroundJobs.pm | 17 +---------------- api/v1/swagger/paths/background_jobs.yaml | 2 ++ 2 files changed, 3 insertions(+), 16 deletions(-) diff --git a/Koha/REST/V1/BackgroundJobs.pm b/Koha/REST/V1/BackgroundJobs.pm index 55f121b403b..cc4c2efcaff 100644 --- a/Koha/REST/V1/BackgroundJobs.pm +++ b/Koha/REST/V1/BackgroundJobs.pm @@ -40,11 +40,7 @@ sub list { my $can_manage_background_jobs = $patron->has_permission( { parameters => 'manage_background_jobs' } ); - my $background_jobs_set = - $can_manage_background_jobs - ? Koha::BackgroundJobs->new - : Koha::BackgroundJobs->search( - { borrowernumber => $patron->borrowernumber } ); + my $background_jobs_set = Koha::BackgroundJobs->search; my $background_jobs = $c->objects->search( $background_jobs_set ); return $c->render( status => 200, openapi => $background_jobs ); @@ -61,10 +57,6 @@ sub get { return try { my $background_job_id = $c->validation->param('background_job_id'); - my $patron = $c->stash('koha.user'); - - my $can_manage_background_jobs = - $patron->has_permission( { parameters => 'manage_background_jobs' } ); my $background_job = Koha::BackgroundJobs->find($background_job_id); @@ -73,13 +65,6 @@ sub get { openapi => { error => "Object not found" } ) unless $background_job; - return $c->render( - status => 403, - openapi => { error => "Cannot see background job info" } - ) - if !$can_manage_background_jobs - && $background_job->borrowernumber != $patron->borrowernumber; - return $c->render( status => 200, openapi => $background_job->to_api diff --git a/api/v1/swagger/paths/background_jobs.yaml b/api/v1/swagger/paths/background_jobs.yaml index c386dfc5c5c..389d56ece97 100644 --- a/api/v1/swagger/paths/background_jobs.yaml +++ b/api/v1/swagger/paths/background_jobs.yaml @@ -87,6 +87,7 @@ x-koha-authorization: permissions: catalogue: "1" + allow-owner: true "/background_jobs/{background_job_id}": get: x-mojo-to: BackgroundJobs#get @@ -125,3 +126,4 @@ x-koha-authorization: permissions: catalogue: "1" + allow-owner: true -- 2.25.1