Bugzilla – Attachment 137175 Details for
Bug 24010
Number of issues to display to staff accepts non-integer values
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24010: (QA follow-up) Correct COMMENT syntax
Bug-24010-QA-follow-up-Correct-COMMENT-syntax.patch (text/plain), 2.32 KB, created by
Tomás Cohen Arazi
on 2022-07-05 14:09:30 UTC
(
hide
)
Description:
Bug 24010: (QA follow-up) Correct COMMENT syntax
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi
Created:
2022-07-05 14:09:30 UTC
Size:
2.32 KB
patch
obsolete
>From 29a9d790e811c2a3139abf75a2f8f05901973c81 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Tue, 5 Jul 2022 11:08:16 -0300 >Subject: [PATCH] Bug 24010: (QA follow-up) Correct COMMENT syntax > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > installer/data/mysql/atomicupdate/bug_24010.pl | 2 ++ > installer/data/mysql/kohastructure.sql | 4 ++-- > 2 files changed, 4 insertions(+), 2 deletions(-) > >diff --git a/installer/data/mysql/atomicupdate/bug_24010.pl b/installer/data/mysql/atomicupdate/bug_24010.pl >index d0bbe10eb1..da0000bea5 100755 >--- a/installer/data/mysql/atomicupdate/bug_24010.pl >+++ b/installer/data/mysql/atomicupdate/bug_24010.pl >@@ -15,6 +15,7 @@ return { > $dbh->do(q{ > ALTER TABLE subscription > MODIFY COLUMN staffdisplaycount INT(11) NULL DEFAULT NULL >+ COMMENT 'how many issues to show to the staff' > }); > > $dbh->do(q{ >@@ -25,6 +26,7 @@ return { > $dbh->do(q{ > ALTER TABLE subscription > MODIFY COLUMN opacdisplaycount INT(11) NULL DEFAULT NULL >+ COMMENT 'how many issues to show to the public' > }); > }, > }; >diff --git a/installer/data/mysql/kohastructure.sql b/installer/data/mysql/kohastructure.sql >index be5382e804..f797810c80 100644 >--- a/installer/data/mysql/kohastructure.sql >+++ b/installer/data/mysql/kohastructure.sql >@@ -4899,8 +4899,8 @@ CREATE TABLE `subscription` ( > `branchcode` varchar(10) COLLATE utf8mb4_unicode_ci NOT NULL DEFAULT '' COMMENT 'default branches (items.homebranch)', > `lastbranch` varchar(10) COLLATE utf8mb4_unicode_ci DEFAULT NULL, > `serialsadditems` tinyint(1) NOT NULL DEFAULT 0 COMMENT 'does receiving this serial create an item record', >- `staffdisplaycount` INT(11) NULL DEFAULT NULL, -- how many issues to show to the staff >- `opacdisplaycount` INT(11) NULL DEFAULT NULL, -- how many issues to show to the public >+ `staffdisplaycount` INT(11) NULL DEFAULT NULL COMMENT 'how many issues to show to the staff', >+ `opacdisplaycount` INT(11) NULL DEFAULT NULL COMMENT 'how many issues to show to the public', > `graceperiod` int(11) NOT NULL DEFAULT 0 COMMENT 'grace period in days', > `enddate` date DEFAULT NULL COMMENT 'subscription end date', > `closed` tinyint(1) NOT NULL DEFAULT 0 COMMENT 'yes / no if the subscription is closed', >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24010
:
95610
|
95717
|
95718
|
95847
|
95935
|
134985
|
134986
|
135092
|
136538
|
136539
|
137060
|
137062
| 137175