From 4596456a4d81947b905a5d833daf8142eab5e969 Mon Sep 17 00:00:00 2001
From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Date: Mon, 27 Jun 2022 11:54:49 +0100
Subject: [PATCH] Bug 28854: (follow-up) Link bundle items to thier biblios

This patch splits out the title formatting from the bundle item title
display into it's own new js-biblio-format include file and adds biblio
linking options.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
---
 .../prog/en/includes/js-biblio-format.inc     | 50 +++++++++++++++++++
 .../prog/en/modules/catalogue/detail.tt       | 15 ++----
 2 files changed, 53 insertions(+), 12 deletions(-)
 create mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/js-biblio-format.inc

diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/js-biblio-format.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/js-biblio-format.inc
new file mode 100644
index 0000000000..32d5b1898e
--- /dev/null
+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/js-biblio-format.inc
@@ -0,0 +1,50 @@
+<script>
+    (function() {
+        /**
+        * Format the biblio response from a Koha RESTful API request.
+        * @param  {Object}  biblio  The biblio json object as returned from the Koha RESTful API
+        * @param  {Object}  config  A configuration object
+        *                           Valid keys are: `link`
+        * @return {string}          The formatted HTML string
+        */
+        window.$biblio_to_html = function( biblio, config ) {
+
+            if ( biblio === undefined ) {
+                return ''; // empty string for no biblio
+            }
+
+            var title = '<span class="biblio-title">';
+            if ( biblio.title != null && biblio.title != '' ) {
+                title += escape_str(biblio.title);
+            } else {
+                title += __("No title");
+            }
+            title += '</span>';
+
+            if ( biblio.subtitle != null && biblio.subtitle != '' ) {
+                title += '<span clas="biblio-subtitle">' + escape_str(biblio.subtitle) + '</span>';
+            }
+
+            if (config && config.link) {
+                if ( config.link === 'marcdetail' ) {
+                    title = '<a href="/cgi-bin/koha/catalogue/MARCdetail.pl?biblionumber='+ encodeURIComponent(biblio.biblio_id) +'">' + title + '</a>';
+                }
+                else if ( config.link === 'labeled_marc') {
+                    title = '<a href="/cgi-bin/koha/catalogue/labeledMARCdetail.pl?biblionumber='+ encodeURIComponent(biblio.biblio_id) +'">' + title + '</a>';
+                }
+                else if ( config.link === 'isbd' ) {
+                    title = '<a href="/cgi-bin/koha/catalogue/ISBDdetail.pl?biblionumber='+ encodeURIComponent(biblio.biblio_id) +'">' + title + '</a>';
+                }
+                else {
+                    title = '<a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber='+ encodeURIComponent(biblio.biblio_id) +'">' + title + '</a>';
+                }
+            }
+
+            if ( biblio.medium != null && biblio.medium != '' ) {
+                title +=  '<span class="biblio-medium">'+escape_str(biblio.medium)+'</span>';
+            }
+
+            return title;
+        };
+    })();
+</script>
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
index ce14db485f..948998e7ba 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
@@ -1598,6 +1598,7 @@ Note that permanent location is a code, and location may be an authval.
     [% INCLUDE 'columns_settings.inc' %]
     [% INCLUDE 'js-date-format.inc' %]
     [% INCLUDE 'js-patron-format.inc' %]
+    [% INCLUDE 'js-biblio-format.inc' %]
     [% Asset.js("js/browser.js") | $raw %]
     [% Asset.js("js/table_filters.js") | $raw %]
     <script>
@@ -1653,22 +1654,12 @@ Note that permanent location is a code, and location may be an authval.
                     } ],
                     "columns": [
                         {
-                            "data": "biblio.title:biblio.medium",
+                            "data": "biblio.title:biblio.subtitle:biblio.medium",
                             "title": _("Title"),
                             "searchable": true,
                             "orderable": true,
                             "render": function(data, type, row, meta) {
-                                var title = "";
-                                if ( row.biblio.title ) {
-                                    title = title.concat('<span class="biblio-title">',row.biblio.title,'</span>');
-                                }
-                                if ( row.biblio.subtitle ) {
-                                    title = title.concat('<span class="biblio-subtitle">',row.biblio.subtitle,'</span>');
-                                }
-                                if ( row.biblio.medium ) {
-                                    title = title.concat('<span class="biblio-medium">',row.biblio.medium,'</span>');
-                                }
-                                return title;
+                                return $biblio_to_html(row.biblio, { link: 1 });
                             }
                         },
                         {
-- 
2.20.1