View | Details | Raw Unified | Return to bug 31112
Collapse All | Expand All

(-)a/t/db_dependent/Circulation.t (-6 / +7 lines)
Lines 1640-1646 subtest "Bug 13841 - Do not create new 0 amount fines" => sub { Link Here
1640
};
1640
};
1641
1641
1642
subtest "AllowRenewalIfOtherItemsAvailable tests" => sub {
1642
subtest "AllowRenewalIfOtherItemsAvailable tests" => sub {
1643
    plan tests => 13;
1643
    plan tests => 12;
1644
    my $biblio = $builder->build_sample_biblio();
1644
    my $biblio = $builder->build_sample_biblio();
1645
    my $item_1 = $builder->build_sample_item(
1645
    my $item_1 = $builder->build_sample_item(
1646
        {
1646
        {
Lines 1816-1822 subtest "AllowRenewalIfOtherItemsAvailable tests" => sub { Link Here
1816
1816
1817
    my $mock_circ = Test::MockModule->new("C4::Circulation");
1817
    my $mock_circ = Test::MockModule->new("C4::Circulation");
1818
    $mock_circ->mock( CanItemBeReserved => sub {
1818
    $mock_circ->mock( CanItemBeReserved => sub {
1819
        warn "Checked";
1820
        return { status => 'no' }
1819
        return { status => 'no' }
1821
    } );
1820
    } );
1822
1821
Lines 1824-1832 subtest "AllowRenewalIfOtherItemsAvailable tests" => sub { Link Here
1824
    $item_3->delete();
1823
    $item_3->delete();
1825
    # Two items total, one item available, one issued, two holds on record
1824
    # Two items total, one item available, one issued, two holds on record
1826
1825
1827
    warnings_are{
1826
    ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $item_1->itemnumber );
1828
       ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $item_1->itemnumber );
1829
    } [], "CanItemBeReserved not called when there are more possible holds than available items";
1830
    is( $renewokay, 0, 'Borrower cannot renew when there are more holds than available items' );
1827
    is( $renewokay, 0, 'Borrower cannot renew when there are more holds than available items' );
1831
1828
1832
    $item_3 = $builder->build_sample_item(
1829
    $item_3 = $builder->build_sample_item(
Lines 1848-1853 subtest "AllowRenewalIfOtherItemsAvailable tests" => sub { Link Here
1848
        }
1845
        }
1849
    );
1846
    );
1850
1847
1848
    $mock_circ->mock( CanItemBeReserved => sub {
1849
        warn "Checked";
1850
        return { status => 'no' }
1851
    } );
1852
1851
    warnings_are{
1853
    warnings_are{
1852
       ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $item_1->itemnumber );
1854
       ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $item_1->itemnumber );
1853
    } ["Checked","Checked"], "CanItemBeReserved only called once per available item if it returns a negative result for all items for a borrower";
1855
    } ["Checked","Checked"], "CanItemBeReserved only called once per available item if it returns a negative result for all items for a borrower";
1854
- 

Return to bug 31112