Bugzilla – Attachment 138012 Details for
Bug 31220
Error when attempting to export selected labels as PDF
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
BUg 31220: Pass label batch and ids to label-create-pdf
BUg-31220-Pass-label-batch-and-ids-to-label-create.patch (text/plain), 3.02 KB, created by
ByWater Sandboxes
on 2022-07-22 11:56:37 UTC
(
hide
)
Description:
BUg 31220: Pass label batch and ids to label-create-pdf
Filename:
MIME Type:
Creator:
ByWater Sandboxes
Created:
2022-07-22 11:56:37 UTC
Size:
3.02 KB
patch
obsolete
>From fe23d527237bcc3c4871399b5f030d5d97ab42bd Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Fri, 22 Jul 2022 11:36:06 +0000 >Subject: [PATCH] BUg 31220: Pass label batch and ids to label-create-pdf > >This patch fixes a malformed link to print selected labels >and fix error: >Can't locate object method "get_attr" via package "-2" (perhaps you forgot to load "-2"?) at /usr/share/koha/intranet/cgi-bin/labels/label-create-pdf.pl line 126. > >To test: >1 - Create a new label batch with some items >2 - Select 1 or more >3 - Export selected labels >4 - Download as PDF >5 - It works! > >Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-print.tt | 2 +- > labels/label-create-pdf.pl | 2 ++ > 2 files changed, 3 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-print.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-print.tt >index 7349d8fb06..2732fe8a12 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-print.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-print.tt >@@ -22,7 +22,7 @@ > <fieldset> > [% IF ( batche.label_ids ) %] > <legend>[% IF ( batche.label_count == 1 ) %][% batche.label_count | html %] single label[% ELSE %][% batche.label_count | html %] single labels[% END %]</legend> >- <a class="document pdf" href="/cgi-bin/koha/labels/label-create-pdf.pl?batch_id=0&template_id=[% batche.template_id | html %]&layout_id=[% batche.layout_id | html %]&start_label=[% batche.start_label | html %]&from=[% batche.from | html %]&to=[% batche.to | html %]&barcode_length=[% batche.barcode_length| html %]">Download as PDF</a> >+ <a class="document pdf" href="/cgi-bin/koha/labels/label-create-pdf.pl?batch_id=[% batche.batch_id %]&template_id=[% batche.template_id | html %]&layout_id=[% batche.layout_id | html %][% batche.label_ids | html %]">Download as PDF</a> > > <p><a class="document csv" href="/cgi-bin/koha/labels/label-create-csv.pl?batch_id=[% batche.batch_id | html %]&template_id=[% batche.template_id | html %]&layout_id=[% batche.layout_id | html %][% batche.label_ids | html %]">Download as CSV</a></p> > >diff --git a/labels/label-create-pdf.pl b/labels/label-create-pdf.pl >index f1cd47183c..46a5da13b7 100755 >--- a/labels/label-create-pdf.pl >+++ b/labels/label-create-pdf.pl >@@ -56,7 +56,9 @@ print $cgi->header( -type => 'application/pdf', > ); > > our $pdf = C4::Creators::PDF->new(InitVars => 0); >+warn Data::Dumper::Dumper( $batch_id ); > my $batch = C4::Labels::Batch->retrieve(batch_id => $batch_id); >+warn Data::Dumper::Dumper( $batch ); > our $template = C4::Labels::Template->retrieve(template_id => $template_id, profile_id => 1); > my $layout = C4::Labels::Layout->retrieve(layout_id => $layout_id); > >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31220
:
138009
|
138012
|
138479
|
138516
|
138517