From 07fbb31776d3d3e76399678c951081352bf4fd9f Mon Sep 17 00:00:00 2001
From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Date: Fri, 22 Mar 2019 08:03:16 +0000
Subject: [PATCH] Bug 17385: (QA follow-up) Do not needlessly scan biblioexport
 folder

Performance: We need to return an empty list if OpacExportOptions does not contain Custom.  No need to scan the directory for custom files, if we are not using them at all.

Note: The test only pertains to OPAC now, since the pref should not control intranet behavior. We have no intranet counterpart. See further next follow-up.

Test plan:
Run t/db_dependent/XSLT.t
---
 C4/XSLT.pm            | 48 +++++++++++++++++++++++++++++++++++++++++++
 t/db_dependent/XSLT.t | 31 +++++++++++-----------------
 2 files changed, 60 insertions(+), 19 deletions(-)

diff --git a/C4/XSLT.pm b/C4/XSLT.pm
index 98b330cac0..7da42cdc39 100644
--- a/C4/XSLT.pm
+++ b/C4/XSLT.pm
@@ -475,6 +475,54 @@ sub engine {
     return $engine;
 }
 
+=head2 CustomXSLTExportList
+
+ Returns list of file for custom xslt conversion
+
+=cut
+
+sub CustomXSLTExportList {
+    my $opac = shift; # opac (1) vs intranet (0)
+    return [] if $opac && C4::Context->preference('OpacExportOptions') !~ /custom/;
+
+    my @tabFiles;
+
+    my $dir = C4::Context->config( $opac ? 'opachtdocs' : 'intrahtdocs') .
+                      '/' . C4::Context->preference( $opac ? "opacthemes" : "template") .
+                      '/' . C4::Languages::getlanguage() .
+                      '/xslt/biblioexport';
+    my @files = glob qq("$dir/*.xsl");
+    foreach my $file (@files) {
+        if ( -f "$file" ) {
+            (my $text = $file) =~ s/.*\///g;
+
+            ## Get title of the option
+            my $dom;
+            eval { $dom = XML::LibXML->load_xml( location => $file ); };
+            next unless $dom;
+
+            my $node = $dom->documentElement();
+            my $title = $node->{"title"};
+            ($title = $text) =~ s/\.xsl// unless defined $title;
+
+            # Get output format
+            # There should only be one xsl:output node, so taking the first one only is OK
+            $node = @{$node->findnodes("xsl:output")}[0];
+            my $outputformat= "";
+            $outputformat = $node->{"method"} if $node;
+            $outputformat = "txt" if ($outputformat eq "" || $outputformat eq "text");
+
+            my %row = (
+                value       => $text,
+                filename    => $title,
+                format      => $outputformat,
+            );
+
+            push @tabFiles, \%row;
+        }
+    }
+    return \@tabFiles;
+}
 1;
 
 __END__
diff --git a/t/db_dependent/XSLT.t b/t/db_dependent/XSLT.t
index 345365a401..69c8828af6 100755
--- a/t/db_dependent/XSLT.t
+++ b/t/db_dependent/XSLT.t
@@ -1,20 +1,3 @@
-#!/usr/bin/perl
-
-# This file is part of Koha.
-#
-# Koha is free software; you can redistribute it and/or modify it
-# under the terms of the GNU General Public License as published by
-# the Free Software Foundation; either version 3 of the License, or
-# (at your option) any later version.
-#
-# Koha is distributed in the hope that it will be useful, but
-# WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with Koha; if not, see <http://www.gnu.org/licenses>.
-
 use Modern::Perl;
 
 use MARC::Record;
@@ -26,15 +9,25 @@ use t::lib::Mocks;
 use Koha::Database;
 use Koha::Libraries;
 use Koha::ItemTypes;
+use C4::XSLT;
 
 BEGIN {
     use_ok('C4::XSLT', qw( transformMARCXML4XSLT getAuthorisedValues4MARCSubfields buildKohaItemsNamespace ));
 }
 
-my $schema  = Koha::Database->new->schema;
-my $builder = t::lib::TestBuilder->new;
+our $schema = Koha::Database->new->schema;
 
+# Here we go
 $schema->storage->txn_begin;
+subtest 'CustomXSLTExportList: Check export options' => sub {
+    plan tests => 2;
+    t::lib::Mocks::mock_preference('OpacExportOptions', 'custom');
+        my $list = C4::XSLT::CustomXSLTExportList(1);
+    is( @$list>0, 1, 'We expect at least one result: simple export' );
+    t::lib::Mocks::mock_preference('OpacExportOptions', 'dc');
+    $list = C4::XSLT::CustomXSLTExportList(1);
+    is( @$list, 0, 'We expect an empty list now' );
+};
 
 subtest 'transformMARCXML4XSLT tests' => sub {
     plan tests => 1;
-- 
2.25.1