From 4ad91671668d5e26bd90211970a80e8de502313f Mon Sep 17 00:00:00 2001 From: The Minh Luong Date: Tue, 8 Mar 2022 11:20:46 -0500 Subject: [PATCH] Bug 17385: Correction of opac-detail-sidebar.inc This patch reverts the changes made in opac-detail-sidebar.inc, so the sidebar is displayed as wanted. Tests are now passing properly. TEST PLAN: 1- Apply the patch and search for a record in the OPAC. 2- Click on "Save record". Notice that the dropdown menu is unchanged. 3- Run t/db_dependent/XSLT.t (All tests should pass) --- .../bootstrap/en/includes/opac-detail-sidebar.inc | 8 +++----- t/db_dependent/XSLT.t | 6 +++--- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-detail-sidebar.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-detail-sidebar.inc index 5d55583297..2634b531c6 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-detail-sidebar.inc +++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-detail-sidebar.inc @@ -63,12 +63,11 @@
Save record - +
diff --git a/t/db_dependent/XSLT.t b/t/db_dependent/XSLT.t index 3d0dfa4c66..d55c06bf03 100755 --- a/t/db_dependent/XSLT.t +++ b/t/db_dependent/XSLT.t @@ -18,7 +18,7 @@ use Modern::Perl; use MARC::Record; -use Test::More tests => 4; +use Test::More tests => 7; use Test::Warn; use t::lib::TestBuilder; use t::lib::Mocks; @@ -46,8 +46,8 @@ subtest 'CustomXSLTExportList: Caching' => sub { push @$list, { nonsense => 1 }; $cache->set_in_cache( 'CustomXSLTExportListOPAC', $list ); my $n = @$list; - $list = C4::XSLT::CustomXSLTExportList(1); is( @$list, $n, 'This list comes from the cache and that is fine' ); + $list = C4::XSLT::CustomXSLTExportList(1); $cache->clear_from_cache('CustomXSLTExportListOPAC'); }; @@ -178,8 +178,8 @@ subtest 'CustomXSLTExportList: Caching' => sub { push @$list, { nonsense => 1 }; $cache->set_in_cache('CustomXSLTExportListOPAC', $list ); my $n = @$list; - $list = C4::XSLT::CustomXSLTExportList(1); is( @$list, $n, 'This list comes from the cache and that is fine' ); + $list = C4::XSLT::CustomXSLTExportList(1); $cache->clear_from_cache('CustomXSLTExportListOPAC'); }; subtest 'CustomXSLTExportList: Check export options' => sub { -- 2.25.1