Bugzilla – Attachment 138688 Details for
Bug 31289
Hide article requests column in circulation rules when ArticleRequests syspref is disabled
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31289: Hide Article requests column in circulation rules when ArticleRequests syspref is disabled
Bug-31289-Hide-Article-requests-column-in-circulat.patch (text/plain), 4.25 KB, created by
Katrin Fischer
on 2022-08-05 12:35:44 UTC
(
hide
)
Description:
Bug 31289: Hide Article requests column in circulation rules when ArticleRequests syspref is disabled
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2022-08-05 12:35:44 UTC
Size:
4.25 KB
patch
obsolete
>From f54132002cfd1d123f04f1023d04686ff2a4eecb Mon Sep 17 00:00:00 2001 >From: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> >Date: Wed, 3 Aug 2022 09:54:27 -0400 >Subject: [PATCH] Bug 31289: Hide Article requests column in circulation rules > when ArticleRequests syspref is disabled > >This patch hides the Article requests column in the large circulation >rules table when the ArticleRequests system preference is disabled. > >To test: >0) Apply patch >1) With ArticleRequests disabled, go to Administration > Circulation and fines > rules >2) Scroll right in the first table >--> There isn't any mention of article requests in the table >3) Scroll down to see the other tables in the page >--> There are no other article requests tables >4) Enable ArticleRequests in Administration > System preferences >5) Go back to the Circulation and fines rules and refresh the page >6) Scroll right in the first table >--> There should be an article requests yes/no column >7) Scroll down to see the other tables in the page >--> There are other article requests tables, Default open article requests > limit and Default article request fees > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> > >Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> >--- > .../intranet-tmpl/prog/en/modules/admin/smart-rules.tt | 8 ++++++++ > 1 file changed, 8 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt >index 5df48a90d7..dc0936efe2 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt >@@ -141,7 +141,9 @@ > <th>Holds per record (count)</th> > <th>On shelf holds allowed</th> > <th>OPAC item level holds</th> >+ [% IF Koha.Preference('ArticleRequests') %] > <th>Article requests</th> >+ [% END %] > <th>Rental discount (%)</th> > [% IF Koha.Preference('UseRecalls') %] > <th>Recalls allowed (total)</th> >@@ -361,6 +363,7 @@ > <span>Don't allow</span> > [% END %] > </td> >+ [% IF Koha.Preference('ArticleRequests') %] > <td> > [% IF article_requests == 'no' %] > <span>No</span> >@@ -372,6 +375,7 @@ > <span>Item only</span> > [% END %] > </td> >+ [% END %] > <td>[% rentaldiscount | html %]</td> > [% IF Koha.Preference('UseRecalls') %] > <td>[% recalls_allowed | html %]</td> >@@ -507,6 +511,7 @@ > <option value="F">Force</option> > </select> > </td> >+ [% IF Koha.Preference('ArticleRequests') %] > <td> > <select id="article_requests" name="article_requests"> > <option value="no">No</option> >@@ -515,6 +520,7 @@ > <option value="item_only">Item only</option> > </select> > </td> >+ [% END %] > <td><input type="text" name="rentaldiscount" id="rentaldiscount" size="2" /></td> > [% IF Koha.Preference('UseRecalls') %] > <td><input type="text" name="recalls_allowed" id="recalls_allowed" size="3"></td> >@@ -573,7 +579,9 @@ > <th>Holds per record (count)</th> > <th>On shelf holds allowed</th> > <th>OPAC item level holds</th> >+ [% IF Koha.Preference('ArticleRequests') %] > <th>Article requests</th> >+ [% END %] > <th>Rental discount (%)</th> > [% IF Koha.Preference('UseRecalls') %] > <th>Recalls allowed (total)</th> >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31289
:
138541
|
138544
| 138688