Bugzilla – Attachment 138744 Details for
Bug 31214
Regression: subfield code editable in MARC framework editor
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31214: Make subfield code non-editable in MARC framework editor
Bug-31214-Make-subfield-code-non-editable-in-MARC-.patch (text/plain), 2.86 KB, created by
Katrin Fischer
on 2022-08-07 11:59:20 UTC
(
hide
)
Description:
Bug 31214: Make subfield code non-editable in MARC framework editor
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2022-08-07 11:59:20 UTC
Size:
2.86 KB
patch
obsolete
>From b7c639e4130d60b9dc0a607a70405c81d22401d4 Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Joonas=20Kylm=C3=A4l=C3=A4?= <joonas.kylmala@iki.fi> >Date: Sun, 7 Aug 2022 11:24:12 +0000 >Subject: [PATCH] Bug 31214: Make subfield code non-editable in MARC framework > editor > >The subfield code field became editable in framework >editor due to a regression that happened during the >switch from a previous template framework koha used >to the new Template toolkit framework currently in use: >Bug 5917 : Swapping templates over (5884fb100071e973daf671a4ada6b32724376768) >The regression happened due to the template syntax >not being updated to the new one in this particular >case. > >Note: The subfield code field doesn't align with the > other fields anymore after this patch. However, > this alignment issue is in every other Koha form > in intranet and should be fixed in the global > CSS rules. > >1) Apply patch >2) Browse to > /cgi-bin/koha/admin/marc_subfields_structure.pl?op=add_form&tagfield=995&frameworkcode=AR >3) Notice the subfield code is non-editable >4) Notice the subfield code is still editable in the New tab. > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > .../prog/en/modules/admin/marc_subfields_structure.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt >index 4120897921..a01a67ec60 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt >@@ -159,11 +159,11 @@ > <fieldset class="rows"> > <legend>Basic constraints</legend> > <ol> >- [% IF ( subfieldcode == 0 || subfieldcode ) %] >+ [% IF ( loo.subfieldcode == 0 || loo.subfieldcode ) %] > <li> > <span class="label">Subfield code:</span> > [% loo.subfieldcode | html %] >- <input type="hidden" name="tagsubfield" value="[% loo.subfieldcode | html %]" /> >+ <input type="hidden" id="tagsubfield[% loo.row | html %]" name="tagsubfield" value="[% loo.subfieldcode | html %]" /> > </li> > [% ELSE %] > <li> >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31214
:
138743
|
138744
|
138891