From 2279cf618138f75fc9a29e57475b5bceff7a7478 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Joonas=20Kylm=C3=A4l=C3=A4?= Date: Sun, 7 Aug 2022 11:24:12 +0000 Subject: [PATCH] Bug 31214: Make subfield code non-editable in MARC framework editor The subfield code field became editable in framework editor due to a regression that happened during the switch from a previous template framework koha used to the new Template toolkit framework currently in use: Bug 5917 : Swapping templates over (5884fb100071e973daf671a4ada6b32724376768) The regression happened due to the template syntax not being updated to the new one in this particular case. Note: The subfield code field doesn't align with the other fields anymore after this patch. However, this alignment issue is in every other Koha form in intranet and should be fixed in the global CSS rules. 1) Apply patch 2) Browse to /cgi-bin/koha/admin/marc_subfields_structure.pl?op=add_form&tagfield=995&frameworkcode=AR 3) Notice the subfield code is non-editable 4) Notice the subfield code is still editable in the New tab. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart --- .../prog/en/modules/admin/marc_subfields_structure.tt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt index 41208979216..a01a67ec601 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt @@ -159,11 +159,11 @@
Basic constraints
    - [% IF ( subfieldcode == 0 || subfieldcode ) %] + [% IF ( loo.subfieldcode == 0 || loo.subfieldcode ) %]
  1. Subfield code: [% loo.subfieldcode | html %] - +
  2. [% ELSE %]
  3. -- 2.25.1