Bugzilla – Attachment 138929 Details for
Bug 31265
Curbside pickups - improve slots selection
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31265: (QA follow-up) Align time selection controls like other inputs
Bug-31265-QA-follow-up-Align-time-selection-contro.patch (text/plain), 2.82 KB, created by
Martin Renvoize
on 2022-08-09 16:16:57 UTC
(
hide
)
Description:
Bug 31265: (QA follow-up) Align time selection controls like other inputs
Filename:
MIME Type:
Creator:
Martin Renvoize
Created:
2022-08-09 16:16:57 UTC
Size:
2.82 KB
patch
obsolete
>From d18075e2a116218ee87417bcb88dc210ebecf73b Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Tue, 9 Aug 2022 16:12:08 +0000 >Subject: [PATCH] Bug 31265: (QA follow-up) Align time selection controls like > other inputs > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > .../bootstrap/en/modules/opac-curbside-pickups.tt | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-curbside-pickups.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-curbside-pickups.tt >index 666f5bbb1d..0e87b9b4c2 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-curbside-pickups.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-curbside-pickups.tt >@@ -20,9 +20,8 @@ > display: flex; > flex-wrap: wrap; > } >- #pickup-times label { >- flex-basis: 100%; >- text-align: center; >+ #pickup-time-slots { >+ max-width: 80%; > } > fieldset.rows .pickup_time label { > background: #e6e6e6 linear-gradient(180deg,#f0f0f0,#e6e6e6); >@@ -357,7 +356,7 @@ > pickupDate._flatpickr.config.onClose.push(function( selectedDates, dateStr, instance ){ > /* Here we add an onClose event to the existing flatpickr instance */ > /* It fires after the user has selected a date from the calendar popup */ >- $('#pickup-times').html("<label>" + _("Select a time") + "</label>"); >+ $('#pickup-times').html("<label>" + _("Select a time") + ":</label><div id=\"pickup-time-slots\"></div>"); > $('#schedule-pickup-button').prop( 'disabled', 1 ); > > var currentDate = dateStr; >@@ -453,7 +452,7 @@ > let pickups_scheduled = pickupSlot.pickups_scheduled; > let pickups_available = policy.patrons_per_interval - pickups_scheduled; > let disabled = pickupSlot.available ? "" : "disabled"; >- $("#pickup-times").append(`<span class="pickup_time"><input type="radio" id="slot_${i}" name="pickup_time" value="${optValue}" ${disabled} /> <label class="pickup_select" for="slot_${i}" data-toggle="tooltip" title="` + _("Appointments available: ") + `${pickups_available}">${optText} <span class="pickups_available">${pickups_available}</span></label></span>`); >+ $("#pickup-time-slots").append(`<span class="pickup_time"><input type="radio" id="slot_${i}" name="pickup_time" value="${optValue}" ${disabled} /> <label class="pickup_select" for="slot_${i}" data-toggle="tooltip" title="` + _("Appointments available: ") + `${pickups_available}">${optText} <span class="pickups_available">${pickups_available}</span></label></span>`); > } > > $("#pickup_notes_item,#pickup-times").show(); >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31265
:
138405
|
138686
|
138747
|
138759
|
138927
|
138928
| 138929