Bugzilla – Attachment 139013 Details for
Bug 31294
Article requests: Mandatory subfields in OPAC don't show they are required
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31294: Show "Required" label on mandatory fields
Bug-31294-Show-Required-label-on-mandatory-fields.patch (text/plain), 5.93 KB, created by
David Cook
on 2022-08-11 05:41:46 UTC
(
hide
)
Description:
Bug 31294: Show "Required" label on mandatory fields
Filename:
MIME Type:
Creator:
David Cook
Created:
2022-08-11 05:41:46 UTC
Size:
5.93 KB
patch
obsolete
>From 46394fd478a5bafe7bb4952a6313cfe6810257d0 Mon Sep 17 00:00:00 2001 >From: David Cook <dcook@prosentient.com.au> >Date: Thu, 11 Aug 2022 05:40:45 +0000 >Subject: [PATCH] Bug 31294: Show "Required" label on mandatory fields > >This patch adds "Required" label on mandatory fields for Article Requests > >0. Apply the patch >1. koha-plack --restart kohadev >2. Change syspref 'ArticleRequests' to 'Enable' >3. Change syspref 'ArticleRequestsMandatoryFields' to '[Select all]' >4. Go to http://localhost:8080/cgi-bin/koha/opac-search.pl?idx=&q=test&weight_search=1 >5. Click "Request article" for "Gairm" >6. Note that "Title", "Author", "Volume", "Issue", "Date", "Pages", and "Chapters" all say required >7. Change syspref 'ArticleRequestsMandatoryFields' to 'Title' and 'Author' >8. Go to http://localhost:8080/cgi-bin/koha/opac-request-article.pl?biblionumber=29 >9. Note that only "Title" and "Author" say required >--- > .../opac-tmpl/bootstrap/en/modules/opac-request-article.tt | 7 +++++++ > 1 file changed, 7 insertions(+) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-request-article.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-request-article.tt >index d11bec9609..4ba935bb8d 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-request-article.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-request-article.tt >@@ -75,6 +75,7 @@ > [% IF mandatory_fields.search('title') %] > <label for="title" class="required">Title:</label> > <input type="text" required="required" name="title" id="title" size="50" value="[% title | html %]"/> >+ <div class="required_label required">Required</div> > [% ELSE %] > <label for="title">Title:</label> > <input type="text" name="title" id="title" size="50" value="[% title | html %]"/> >@@ -85,6 +86,7 @@ > [% IF mandatory_fields.search('author') %] > <label for="author" class="required">Author:</label> > <input type="text" required="required" name="author" id="author" size="50" value="[% author | html %]"/> >+ <div class="required_label required">Required</div> > [% ELSE %] > <label for="author">Author:</label> > <input type="text" name="author" id="author" size="50" value="[% author | html %]"/> >@@ -95,6 +97,7 @@ > [% IF mandatory_fields.search('volume') %] > <label for="volume" class="required">Volume:</label> > <input type="text" required="required" name="volume" id="volume" size="50"/> >+ <div class="required_label required">Required</div> > [% ELSE %] > <label for="volume">Volume:</label> > <input type="text" name="volume" id="volume" size="50"/> >@@ -105,6 +108,7 @@ > [% IF mandatory_fields.search('issue') %] > <label for="issue" class="required">Issue:</label> > <input type="text" required="required" name="issue" id="issue" size="50"/> >+ <div class="required_label required">Required</div> > [% ELSE %] > <label for="issue">Issue:</label> > <input type="text" name="issue" id="issue" size="50"/> >@@ -115,6 +119,7 @@ > [% IF mandatory_fields.search('date') %] > <label for="date" class="required">Date:</label> > <input type="text" required="required" name="date" id="date" size="50"/> >+ <div class="required_label required">Required</div> > [% ELSE %] > <label for="date">Date:</label> > <input type="text" name="date" id="date" size="50"/> >@@ -130,6 +135,7 @@ > [% IF mandatory_fields.search('pages') %] > <label for="pages" class="required">Pages:</label> > <input type="text" required="required" name="pages" id="pages" size="50" value="[% pageinfo | html %]"/> >+ <div class="required_label required">Required</div> > [% ELSE %] > <label for="pages">Pages:</label> > <input type="text" name="pages" id="pages" size="50" value="[% pageinfo | html %]"/> >@@ -140,6 +146,7 @@ > [% IF mandatory_fields.search('chapters') %] > <label for="chapters" class="required">Chapters:</label> > <input type="text" required="required" name="chapters" id="chapters" size="50"/> >+ <div class="required_label required">Required</div> > [% ELSE %] > <label for="chapters">Chapters:</label> > <input type="text" name="chapters" id="chapters" size="50"/> >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31294
:
139013
|
139023
|
139055