From 02c7f313a454c5e8dcb6c6516c0f61c0de43899a Mon Sep 17 00:00:00 2001
From: Kyle M Hall <kyle@bywatersolutions.com>
Date: Thu, 28 Mar 2019 07:12:37 -0400
Subject: [PATCH] Bug 20256: Update groups editor

Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
---
 admin/library_groups.pl                       |  4 +++
 .../prog/en/modules/admin/library_groups.tt   | 25 ++++++++++++++++---
 2 files changed, 26 insertions(+), 3 deletions(-)

diff --git a/admin/library_groups.pl b/admin/library_groups.pl
index 5284a881f4..7bed778c27 100755
--- a/admin/library_groups.pl
+++ b/admin/library_groups.pl
@@ -47,6 +47,7 @@ if ( $action eq 'add' ) {
     my $description = $cgi->param('description') || undef;
     my $branchcode  = $cgi->param('branchcode')  || undef;
     my $ft_hide_patron_info    = $cgi->param('ft_hide_patron_info')    || 0;
+    my $ft_limit_item_editing  = $cgi->param('ft_limit_item_editing')  || 0;
     my $ft_search_groups_opac  = $cgi->param('ft_search_groups_opac')  || 0;
     my $ft_search_groups_staff = $cgi->param('ft_search_groups_staff') || 0;
     my $ft_local_hold_group = $cgi->param('ft_local_hold_group') || 0;
@@ -65,6 +66,7 @@ if ( $action eq 'add' ) {
                     ft_search_groups_opac  => $ft_search_groups_opac,
                     ft_search_groups_staff => $ft_search_groups_staff,
                     ft_local_hold_group    => $ft_local_hold_group,
+                    ft_limit_item_editing  => $ft_limit_item_editing,
                     branchcode             => $branchcode,
                 }
             )->store();
@@ -82,6 +84,7 @@ elsif ( $action eq 'edit' ) {
     my $title       = $cgi->param('title')       || undef;
     my $description = $cgi->param('description') || undef;
     my $ft_hide_patron_info    = $cgi->param('ft_hide_patron_info')    || 0;
+    my $ft_limit_item_editing  = $cgi->param('ft_limit_item_editing')  || 0;
     my $ft_search_groups_opac  = $cgi->param('ft_search_groups_opac')  || 0;
     my $ft_search_groups_staff = $cgi->param('ft_search_groups_staff') || 0;
     my $ft_local_hold_group = $cgi->param('ft_local_hold_group') || 0;
@@ -94,6 +97,7 @@ elsif ( $action eq 'edit' ) {
                 title       => $title,
                 description => $description,
                 ft_hide_patron_info      => $ft_hide_patron_info,
+                ft_limit_item_editing    => $ft_limit_item_editing,
                 ft_search_groups_opac    => $ft_search_groups_opac,
                 ft_search_groups_staff   => $ft_search_groups_staff,
                 ft_local_hold_group   => $ft_local_hold_group,
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/library_groups.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/library_groups.tt
index 9686e1b9c4..f4d7281832 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/library_groups.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/library_groups.tt
@@ -129,6 +129,12 @@
                                         Limit patron data access by group
                                     </label>
                                 </p>
+                                <p>
+                                    <label>
+                                        <input type="checkbox" name="ft_limit_item_editing" id="add-group-modal-ft_limit_item_editing" value="1" />
+                                        Limit item editing by group
+                                    </label>
+                                </p>
                                 <p>
                                     <label>
                                         <input type="checkbox" name="ft_search_groups_opac" id="add-group-modal-ft_search_groups_opac" value="1" />
@@ -193,6 +199,12 @@
                                         Limit patron data access by group
                                     </label>
                                 </p>
+                                <p>
+                                    <label>
+                                        <input type="checkbox" id="edit-group-modal-ft_limit_item_editing" name="ft_limit_item_editing" value="1" />
+                                        Limit item editing by group
+                                    </label>
+                                </p>
                                 <p>
                                     <label>
                                         <input type="checkbox" id="edit-group-modal-ft_search_groups_opac" name="ft_search_groups_opac" value="1" />
@@ -288,10 +300,11 @@
                 var title = $(this).data('groupTitle');
                 var description = $(this).data('groupDescription');
                 var ft_hide_patron_info = $(this).data('groupFt_hide_patron_info');
+                var ft_limit_item_editing = $(this).data('groupFt_limit_item_editing');
                 var ft_search_groups_opac = $(this).data('groupFt_search_groups_opac');
                 var ft_search_groups_staff = $(this).data('groupFt_search_groups_staff');
                 var ft_local_hold_group = $(this).data('groupFt_local_hold_group');
-                edit_group( id, parent_id, title, description, ft_hide_patron_info, ft_search_groups_opac, ft_search_groups_staff, ft_local_hold_group );
+                edit_group( id, parent_id, title, description, ft_hide_patron_info, ft_search_groups_opac, ft_search_groups_staff, ft_local_hold_group, ft_limit_item_editing );
             });
 
             $('.delete-group').on('click', function(e) {
@@ -324,6 +337,7 @@
 
 
             $('#add-group-modal-ft_hide_patron_info').prop('checked', false);
+            $('#add-group-modal-ft_limit_item_editing').prop('checked', false);
             $('#add-group-modal-ft_search_groups_opac').prop('checked', false);
             $('#add-group-modal-ft_search_groups_staff').prop('checked', false);
             $('#add-group-modal-ft_local_hold_group').prop('checked', false);
@@ -336,19 +350,21 @@
 
         }
 
-        function edit_group( id, parent_id, title, description, ft_hide_patron_info, ft_search_groups_opac, ft_search_groups_staff, ft_local_hold_group ) {
+        function edit_group( id, parent_id, title, description, ft_hide_patron_info, ft_search_groups_opac, ft_search_groups_staff, ft_local_hold_group, ft_limit_item_editing ) {
             $('#edit-group-modal-id').val( id );
             $('#edit-group-modal-title').val( title );
             $('#edit-group-modal-description').val( description );
 
             if ( parent_id ) {
                 $('#edit-group-modal-ft_hide_patron_info').prop('checked', false);
+                $('#edit-group-modal-ft_limit_item_editing').prop('checked', false);
                 $('#edit-group-modal-ft_search_groups_opac').prop('checked', false);
                 $('#edit-group-modal-ft_search_groups_staff').prop('checked', false);
                 $('#edit-group-modal-ft_local_hold_group').prop('checked', false);
                 $('#root-group-features-edit').hide();
             } else {
                 $('#edit-group-modal-ft_hide_patron_info').prop('checked', ft_hide_patron_info ? true : false );
+                $('#edit-group-modal-ft_limit_item_editing').prop('checked', ft_limit_item_editing ? true : false );
                 $('#edit-group-modal-ft_search_groups_opac').prop('checked', ft_search_groups_opac ? true : false );
                 $('#edit-group-modal-ft_search_groups_staff').prop('checked', ft_search_groups_staff ? true : false );
                 $('#edit-group-modal-ft_local_hold_group').prop('checked', ft_local_hold_group ? true : false );
@@ -398,6 +414,9 @@
                 [% IF group.ft_hide_patron_info %]
                     <li>Hide patron's info for librarians outside of this group.</li>
                 [% END %]
+                [% IF group.ft_limit_item_editing %]
+                    <li>Limit item editing for librarians outside of this group.</li>
+                [% END %]
                 [% IF group.ft_search_groups_opac %]
                     <li>Use for OPAC search groups</li>
                 [% END %]
@@ -424,7 +443,7 @@
                        </li>
 
                         <li>
-                            <a class="edit-group" id="edit-group-[% group.id | html %]" href="#" data-group-id="[% group.id | html %]" data-group-parent-id="[% group.parent_id | html %]" data-group-title="[% group.title | html %]" data-group-description="[% group.description | html %]" data-group-ft_hide_patron_info="[% group.ft_hide_patron_info | html %]" data-group-ft_search_groups_opac="[% group.ft_search_groups_opac | html %]" data-group-ft_search_groups_staff="[% group.ft_search_groups_staff | html %]" data-group-ft_local_hold_group="[% group.ft_local_hold_group | html %]" >
+                            <a class="edit-group" id="edit-group-[% group.id | html %]" href="#" data-group-id="[% group.id | html %]" data-group-parent-id="[% group.parent_id | html %]" data-group-title="[% group.title | html %]" data-group-description="[% group.description | html %]" data-group-ft_hide_patron_info="[% group.ft_hide_patron_info | html %]" data-group-ft_search_groups_opac="[% group.ft_search_groups_opac | html %]" data-group-ft_search_groups_staff="[% group.ft_search_groups_staff | html %]" data-group-ft_local_hold_group="[% group.ft_local_hold_group | html %]" data-group-ft_limit_item_editing="[% group.ft_limit_item_editing | html %]" >
                                 <i class="fa fa-pencil"></i> Edit
                             </a>
                        </li>
-- 
2.30.2