Bugzilla – Attachment 139249 Details for
Bug 31382
Cannot reach password reset page when password expired
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31382: Pass password_has_expired param to templte
Bug-31382-Pass-passwordhasexpired-param-to-templte.patch (text/plain), 1.46 KB, created by
Nick Clemens (kidclamp)
on 2022-08-17 11:12:30 UTC
(
hide
)
Description:
Bug 31382: Pass password_has_expired param to templte
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2022-08-17 11:12:30 UTC
Size:
1.46 KB
patch
obsolete
>From 6c97af2b4d725c409bd9bbdb9c0b4e59024bd3fe Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Wed, 17 Aug 2022 11:09:14 +0000 >Subject: [PATCH] Bug 31382: Pass password_has_expired param to templte > >This patch restores the param, while still leaving the check against invalid >login credentials to ensure we don't leak information. > >To test: > 1 - enable EnableExpiredPasswordReset > 2 - Edit a patron to set password to expire in the past > 3 - Attempt opac login as patron > 4 - It fails, but you are redirected to login screen with no info > 5 - Apply patch > 6 - Attempt login > 7 - You are notified password expired and given reset link > 8 - Go back to login screen > 9 - Login with correct username,, wrong password >10 - You are notified of incorrect credentials, not password expiration >--- > C4/Auth.pm | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/C4/Auth.pm b/C4/Auth.pm >index 7cf4c9dbc8..99047e4e0e 100644 >--- a/C4/Auth.pm >+++ b/C4/Auth.pm >@@ -1408,6 +1408,7 @@ sub checkauth { > PatronSelfRegistrationDefaultCategory => C4::Context->preference("PatronSelfRegistrationDefaultCategory"), > opac_css_override => $ENV{'OPAC_CSS_OVERRIDE'}, > too_many_login_attempts => ( $patron and $patron->account_locked ), >+ password_has_expired => ( $patron and $patron->password_expired ), > ); > > $template->param( SCO_login => 1 ) if ( $query->param('sco_user_login') ); >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31382
:
139249
|
139297
|
139302
|
139303