Bugzilla – Attachment 139467 Details for
Bug 30718
Use flatpickr's altInput option everywhere
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30718: (QA follow-up) KohaDates filter on inputs
Bug-30718-QA-follow-up-KohaDates-filter-on-inputs.patch (text/plain), 8.72 KB, created by
Marcel de Rooy
on 2022-08-19 09:45:13 UTC
(
hide
)
Description:
Bug 30718: (QA follow-up) KohaDates filter on inputs
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2022-08-19 09:45:13 UTC
Size:
8.72 KB
patch
obsolete
>From 821e0b7b18f891ebef8684e529746562ef1b76fa Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 19 Aug 2022 09:04:49 +0000 >Subject: [PATCH] Bug 30718: (QA follow-up) KohaDates filter on inputs >Content-Type: text/plain; charset=utf-8 > >Found another one on a visible input. Replaced with html filter. >koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep2.tt: <input type="text" class="enrolmentperioddate" name="enrolmentperioddate" id="enrolmentperioddate" value="[% category.enrolmentperioddate | $KohaDates %]" /> > >But we also have a few hidden ones. First verified that cleanborrowers did not work anymore with expirydate. >Fixed it with passing iso dateformat to resolve. >intranet-tmpl/prog/en/modules/acqui/parcels.tt: <input type="hidden" name="shipmentdate" value="[% shipmentdate | $KohaDates %]" /> >intranet-tmpl/prog/en/modules/serials/subscription-add.tt: <input type="hidden" id="acqui_date" name="firstacquidate" value="[% firstacquidate | $KohaDates %]"/> >intranet-tmpl/prog/en/modules/tools/batch_extend_due_dates.tt: <input type="hidden" name="new_hard_due_date" value="[% new_hard_due_date | $KohaDates %]" /> >intranet-tmpl/prog/en/modules/tools/cleanborrowers.tt: <input type="hidden" name="not_borrowed_since" value="[% not_borrowed_since | $KohaDates %]" /> >intranet-tmpl/prog/en/modules/tools/cleanborrowers.tt: <input type="hidden" name="last_issue_date" value="[% last_issue_date | $KohaDates %]" /> >intranet-tmpl/prog/en/modules/tools/cleanborrowers.tt: <input type="hidden" name="borrower_dateexpiry" value="[% borrower_dateexpiry | $KohaDates %]" /> >intranet-tmpl/prog/en/modules/tools/cleanborrowers.tt: <input type="hidden" name="borrower_lastseen" value="[% borrower_lastseen | $KohaDates %]" /> > >Test plan: >Try cleanborrowers with expiry date. >cd koha-tmpl; git grep "<input.*\$KohaDates" | grep -v iso > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcels.tt | 2 +- > .../prog/en/modules/onboarding/onboardingstep2.tt | 2 +- > .../prog/en/modules/serials/subscription-add.tt | 2 +- > .../prog/en/modules/tools/batch_extend_due_dates.tt | 2 +- > .../intranet-tmpl/prog/en/modules/tools/cleanborrowers.tt | 8 ++++---- > 5 files changed, 8 insertions(+), 8 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcels.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcels.tt >index 191b7a92e8..97f6bd7040 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcels.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcels.tt >@@ -65,7 +65,7 @@ > <input type="hidden" name="booksellerid" value="[% booksellerid | html %]" /> > <input type="hidden" name="op" value="confirm" /> > <input type="hidden" name="invoice" value="[% invoicenumber | html %]" /> >- <input type="hidden" name="shipmentdate" value="[% shipmentdate | $KohaDates %]" /> >+ <input type="hidden" name="shipmentdate" value="[% shipmentdate | $KohaDates dateformat => 'iso' %]" /> > <input type="hidden" name="shipmentcost" value="[% shipmentcost | html %]" /> > <input type="hidden" name="shipmentcost_budgetid" value="[% shipmentcost_budgetid | html %]" /> > <input type="submit" class="button" value="Create new invoice anyway" /> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep2.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep2.tt >index edc3088c0f..d84d0d7fe2 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep2.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep2.tt >@@ -121,7 +121,7 @@ > </li> > <li> > <label for="enrolmentperioddate">Until date: </label> >- <input type="text" class="enrolmentperioddate" name="enrolmentperioddate" id="enrolmentperioddate" value="[% category.enrolmentperioddate | $KohaDates %]" /> >+ <input type="text" class="enrolmentperioddate" name="enrolmentperioddate" id="enrolmentperioddate" value="[% category.enrolmentperioddate | html %]" /> > <div class="hint">[% INCLUDE 'date-format.inc' dateformat = Koha.Preference('dateformat') %]</div> > </li> > </ol> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt >index e6406094fb..18595d475d 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt >@@ -305,7 +305,7 @@ fieldset.rows table { clear: none; margin: 0; } > <input type="text" size="10" id="acqui_date" name="firstacquidate" value="[% firstacquidate | html %]" class="flatpickr required" required="required" /> > [% ELSE %] > [% firstacquidate | $KohaDates %] >- <input type="hidden" id="acqui_date" name="firstacquidate" value="[% firstacquidate | $KohaDates %]"/> >+ <input type="hidden" id="acqui_date" name="firstacquidate" value="[% firstacquidate | $KohaDates dateformat => 'iso' %]"/> > [% END %] > <span class="required">Required</span> > </li> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_extend_due_dates.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_extend_due_dates.tt >index 17e8635501..ac1cc8f78d 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_extend_due_dates.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_extend_due_dates.tt >@@ -161,7 +161,7 @@ > <div class="note"><i class="fa fa-exclamation"></i> Reminder: this action will modify all selected checkouts!</div> > <fieldset class="action"> > <input type="hidden" name="op" value="modify" /> >- <input type="hidden" name="new_hard_due_date" value="[% new_hard_due_date | $KohaDates %]" /> >+ <input type="hidden" name="new_hard_due_date" value="[% new_hard_due_date | $KohaDates dateformat => 'iso' %]" /> > <input type="hidden" name="due_date_days" value="[% due_date_days | html %]" /> > <input type="submit" value="Modify selected checkouts" class="button" /> > <a class="cancel" href="/cgi-bin/koha/tools/batch_extend_due_dates.pl">Cancel</a> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/cleanborrowers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/cleanborrowers.tt >index 05e70eb768..6aef847551 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/cleanborrowers.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/cleanborrowers.tt >@@ -222,11 +222,11 @@ > [% END %] > > <input type="hidden" name="step" value="3" /> >- <input type="hidden" name="not_borrowed_since" value="[% not_borrowed_since | $KohaDates %]" /> >- <input type="hidden" name="last_issue_date" value="[% last_issue_date | $KohaDates %]" /> >- <input type="hidden" name="borrower_dateexpiry" value="[% borrower_dateexpiry | $KohaDates %]" /> >+ <input type="hidden" name="not_borrowed_since" value="[% not_borrowed_since | $KohaDates dateformat => 'iso' %]" /> >+ <input type="hidden" name="last_issue_date" value="[% last_issue_date | $KohaDates dateformat => 'iso' %]" /> >+ <input type="hidden" name="borrower_dateexpiry" value="[% borrower_dateexpiry | $KohaDates dateformat => 'iso' %]" /> > [% IF Koha.Preference('TrackLastPatronActivity') %] >- <input type="hidden" name="borrower_lastseen" value="[% borrower_lastseen | $KohaDates %]" /> >+ <input type="hidden" name="borrower_lastseen" value="[% borrower_lastseen | $KohaDates dateformat => 'iso' %]" /> > [% END %] > <input type="hidden" name="borrower_categorycode" value="[% borrower_categorycode | html %]" /> > <input type="hidden" name="patron_list_id" value="[% patron_list_id | html %]" /> >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30718
:
135487
|
137516
|
137707
|
137715
|
137803
|
137804
|
137805
|
137806
|
137807
|
137868
|
137869
|
138644
|
138645
|
138646
|
138647
|
138648
|
138649
|
138650
|
138651
|
138652
|
138658
|
138659
|
138748
|
138749
|
138750
|
138751
|
138752
|
138753
|
138754
|
138755
|
138756
|
138757
|
138758
|
138879
|
138980
|
139033
|
139073
|
139074
|
139075
|
139076
|
139077
|
139078
|
139079
|
139080
|
139081
|
139082
|
139083
|
139084
|
139085
|
139453
|
139454
|
139455
|
139456
|
139457
|
139458
|
139459
|
139460
|
139461
|
139462
|
139463
|
139464
|
139465
|
139466
| 139467 |
139468
|
139490
|
139605
|
143175