Bugzilla – Attachment 139592 Details for
Bug 31436
AllowRenewalIfOtherItemsAvailable should not take suspended holds into account
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31436: AllowRenewalIfOtherItemsAvailable should not take suspended holds into account
Bug-31436-AllowRenewalIfOtherItemsAvailable-should.patch (text/plain), 1.08 KB, created by
Kyle M Hall
on 2022-08-22 11:22:24 UTC
(
hide
)
Description:
Bug 31436: AllowRenewalIfOtherItemsAvailable should not take suspended holds into account
Filename:
MIME Type:
Creator:
Kyle M Hall
Created:
2022-08-22 11:22:24 UTC
Size:
1.08 KB
patch
obsolete
>From 6cca75099d50ff8969c2139eab1da6a2559fea47 Mon Sep 17 00:00:00 2001 >From: Kyle Hall <kyle@bywatersolutions.com> >Date: Mon, 22 Aug 2022 07:21:30 -0400 >Subject: [PATCH] Bug 31436: AllowRenewalIfOtherItemsAvailable should not take > suspended holds into account > >If AllowRenewalIfOtherItemsAvailable is enabled, Koha checks to make sure all other holds are fillable before renewing. >It doesn't make sense to look at suspended holds for this reason, as they are by definition, unfillable. >--- > C4/Circulation.pm | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index 606d83940b..4f0e96a8b1 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -2950,7 +2950,10 @@ sub CanBookBeRenewed { > { > my $biblio = Koha::Biblios->find($item->biblionumber); > my @possible_holds = $biblio->current_holds->unfilled->search( >- {non_priority => 0}, >+ { >+ non_priority => 0, >+ suspend => 0, >+ }, > { prefetch => 'patron' } > )->as_list; > >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31436
: 139592