From 74f4751ac15ff2efb22ca4d5d6826aecdd4251ed Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Wed, 24 Oct 2012 11:02:28 -0400 Subject: [PATCH] Bug 8955 - Self checkout should degrade gracefully with JavaScript turned off Several changes in this patch, the largest of which is that the renew/return dialogs no longer require JavaScript in order to properly alter and submit the form. Instead each button uses a separate form. To test, log in to self checkout and submit a barcode which is checked out and can be renewd, and a barcode which is checked out but has reached the checkout limit. On the resulting dialogs each button should function properly. Also changed: I removed some useless JavaScript processing related to a bogus "valid_session" variable which was unused. Similarly removed is template logic based on a "timedout" variable which was not set by the script. Note that the script contains NO server- side handling of timeout. Timeout is dependent on JavaScript. To test these changes, confirm that with JavaScript enabled you are automatically logged out after the time specified in the SelfCheckTimeout preference. Other minor changes: Terminology and capitalization corrections, minor style tweaks. Signed-off-by: Kyle M Hall Signed-off-by: Chris Cormack --- koha-tmpl/opac-tmpl/prog/en/css/sco.css | 4 + .../opac-tmpl/prog/en/modules/sco/sco-main.tt | 94 +++++++++++--------- opac/sco/sco-main.pl | 3 +- 3 files changed, 56 insertions(+), 45 deletions(-) diff --git a/koha-tmpl/opac-tmpl/prog/en/css/sco.css b/koha-tmpl/opac-tmpl/prog/en/css/sco.css index 4d8e25a..0a81ddd 100644 --- a/koha-tmpl/opac-tmpl/prog/en/css/sco.css +++ b/koha-tmpl/opac-tmpl/prog/en/css/sco.css @@ -138,6 +138,7 @@ div.message { .dialog input.back { background : #FFF url(/opac-tmpl/lib/famfamfam/silk/arrow_left.png) no-repeat 4px center; + border: 1px solid #BCBCBC; padding : .4em .4em .4em 25px; } @@ -336,3 +337,6 @@ span.lang{ div.ft { clear : both; } +.inline { + display: inline; +} \ No newline at end of file diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/sco/sco-main.tt b/koha-tmpl/opac-tmpl/prog/en/modules/sco/sco-main.tt index 66cace5..785451f 100644 --- a/koha-tmpl/opac-tmpl/prog/en/modules/sco/sco-main.tt +++ b/koha-tmpl/opac-tmpl/prog/en/modules/sco/sco-main.tt @@ -10,10 +10,8 @@