From 254546b6a99435eb56bf37b3d19c3c2de1cd1694 Mon Sep 17 00:00:00 2001 From: Martin Renvoize Date: Mon, 15 Mar 2021 16:02:34 +0000 Subject: [PATCH] Bug 24295: Remove GetTransfers from opac-detail.pl MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This patch replaces the call to GetTransfers in opac-detail with the get_transfer method available from the Koha::Item object Test plan 1/ Trigger the transfer of the item 2/ Check the opac-detail page for the display of the current transfer status 3/ Apply patch 4/ Repeat step 2 JK: Remove unneeded string formatting for transfertwhen as it's done on the template toolkit side already with $KohaDates Rebased-by: Joonas Kylmälä Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize --- opac/opac-detail.pl | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/opac/opac-detail.pl b/opac/opac-detail.pl index 1c5e7949ab..cd68ff83fa 100755 --- a/opac/opac-detail.pl +++ b/opac/opac-detail.pl @@ -45,7 +45,6 @@ use C4::Biblio qw( GetMarcSubjects GetMarcUrls ); -use C4::Circulation qw( GetTransfers ); use C4::Tags qw( get_tags ); use C4::XISBN qw( get_xisbns ); use C4::External::Amazon qw( get_amazon_tld ); @@ -734,12 +733,11 @@ else { if ( $reserve_status eq "Waiting" ) { $item_info->{'waiting'} = 1; } if ( $reserve_status eq "Reserved" ) { $item_info->{'onhold'} = 1; } - my ( $transfertwhen, $transfertfrom, $transfertto ) = - GetTransfers( $item->itemnumber ); - if ( defined($transfertwhen) && $transfertwhen ne '' ) { - $item_info->{transfertwhen} = $transfertwhen; - $item_info->{transfertfrom} = $transfertfrom; - $item_info->{transfertto} = $transfertto; + my $transfer = $item->get_transfer; + if ( $transfer && $transfer->in_transit ) { + $item_info->{transfertwhen} = $transfer->datesent; + $item_info->{transfertfrom} = $transfer->frombranch; + $item_info->{transfertto} = $transfer->tobranch; } if ( C4::Context->preference('OPACAcquisitionDetails') ) { -- 2.20.1