From db93aca13df704b4c8bb7f7466f8ad0c502a940a Mon Sep 17 00:00:00 2001 From: Andrew Nugged Date: Thu, 10 Feb 2022 00:03:38 +0200 Subject: [PATCH] Bug 20447: (QA follow-up) Bugfix: Do not force first item for acqorder from biblionumber, but use framework. Note / bigger bug: this happened only for first added item, all next other items in same basket were added without sending biblionumber as in original Koha code: so, this is very suspicious change without any person to explain why. This rolled-back code looks like unfinished feature or mistake. So I will leave this comment especially for future checks, if extension or this feature development will be needed. Signed-off-by: Nick Clemens --- koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt | 2 +- koha-tmpl/intranet-tmpl/prog/js/additem.js | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt index 40b20f6883..4b085fb798 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt @@ -626,7 +626,7 @@ $(document).ready(function(){ [% IF AcqCreateItemOrdering and not basket.is_standing %] - cloneItemBlock(0, '[% UniqueItemFields | html %]', null, [% biblionumber | html %]); + cloneItemBlock(0, '[% UniqueItemFields | html %]'); [% END %] [% IF ( suggestionid ) %]updateCosts();[% END %] diff --git a/koha-tmpl/intranet-tmpl/prog/js/additem.js b/koha-tmpl/intranet-tmpl/prog/js/additem.js index 40b84b6590..e51204707e 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/additem.js +++ b/koha-tmpl/intranet-tmpl/prog/js/additem.js @@ -150,7 +150,7 @@ function deleteItemBlock(node_a, index, unique_item_fields) { } } -function cloneItemBlock(index, unique_item_fields, callback, biblionumber) { +function cloneItemBlock(index, unique_item_fields, callback) { var original; if(index) { original = $("#" + index); //original
@@ -167,7 +167,6 @@ function cloneItemBlock(index, unique_item_fields, callback, biblionumber) { url: "/cgi-bin/koha/services/itemrecorddisplay.pl", dataType: 'html', data: { - biblionumber: biblionumber, frameworkcode: 'ACQ' }, success: function(data) { -- 2.37.2