Bugzilla – Attachment 139947 Details for
Bug 15545
Remove remainders of unfinished reqholdnotes functionality
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15545: Remove reqholdnotes from opac-reserve
Bug-15545-Remove-reqholdnotes-from-opac-reserve.patch (text/plain), 3.03 KB, created by
Marcel de Rooy
on 2022-08-29 13:48:57 UTC
(
hide
)
Description:
Bug 15545: Remove reqholdnotes from opac-reserve
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2022-08-29 13:48:57 UTC
Size:
3.03 KB
patch
obsolete
>From 68b378848db7ee553597ebd72c628597fd0ad39a Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Mon, 29 Aug 2022 13:40:28 +0000 >Subject: [PATCH] Bug 15545: Remove reqholdnotes from opac-reserve >Content-Type: text/plain; charset=utf-8 > >This never really made it. So let's remove all traces. > >Test plan: >Look at code changes and git grep reqholdnotes. >Bonus: Place a hold with/without hold notes. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt | 6 ------ > opac/opac-reserve.pl | 1 - > 2 files changed, 7 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt >index b45ed20983..a43b084032 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt >@@ -317,9 +317,6 @@ > <li> > <div class="notesrow" id="notesrow_[% bibitemloo.biblionumber | html %]"> > <label for="holdnotes_[% bibitemloo.biblionumber | html %]">Hold notes:</label> >- [% IF bibitemloo.reqholdnotes %] >- <span id="reqholdnotes_[% bibitemloo.biblionumber | html %]">Please enter additional information about the requested item:</span> >- [% END %] > <textarea id="holdnotes_[% bibitemloo.biblionumber | html %]" rows="2" cols="30" name="notes_[% bibitemloo.biblionumber | html %]" >[% bibitemloo.holdnotes | html %]</textarea> > </div> > </li> >@@ -558,9 +555,6 @@ > $("#reqspecific_[% bibitemloo.biblionumber | html %]").click(); > $("#copiesrow_[% bibitemloo.biblionumber | html %]").show(); > [% END %] >- [% IF bibitemloo.reqholdnotes %] >- $("#holdnotes_[% bibitemloo.biblionumber | html %]").attr( 'required', true ); >- [% END %] > [% END %] > > // Replace non-JS single-selection with multi-selection capability. >diff --git a/opac/opac-reserve.pl b/opac/opac-reserve.pl >index 4c9119540b..bd6dc9bc7c 100755 >--- a/opac/opac-reserve.pl >+++ b/opac/opac-reserve.pl >@@ -441,7 +441,6 @@ foreach my $biblioNum (@biblionumbers) { > $biblioLoopIter{rank} = $biblioData->{rank}; > $biblioLoopIter{reservecount} = $biblioData->{reservecount}; > $biblioLoopIter{already_reserved} = $biblioData->{already_reserved}; >- $biblioLoopIter{reqholdnotes}=0; #TODO: For future use > > if (!$itemLevelTypes && $biblioData->{itemtype}) { > $biblioLoopIter{translated_description} = $itemtypes->{$biblioData->{itemtype}}{translated_description}; >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15545
:
46687
|
46688
|
46689
|
49084
|
49085
|
49086
|
51832
|
51833
|
51834
|
53546
|
53547
|
59252
|
59253
|
139947
|
140960