From 3febe28e44219412cc35ca0597adb50e435322c4 Mon Sep 17 00:00:00 2001 From: Mason James Date: Wed, 12 Dec 2012 02:43:29 +1300 Subject: [PATCH] Bug 8299 - overdue_notice.pl shows error messages Content-Type: text/plain; charset="utf-8" http://koha-community.org fixes 2 warnings... Use of uninitialized value in pattern match (m//) at /usr/share/koha/bin/cronjobs/overdue_notices.pl line 659. Use of uninitialized value in pattern match (m//) at /usr/share/koha/bin/cronjobs/overdue_notices.pl line 670. --- misc/cronjobs/overdue_notices.pl | 10 ++++++++-- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/misc/cronjobs/overdue_notices.pl b/misc/cronjobs/overdue_notices.pl index e83bd39..7eb4fe0 100755 --- a/misc/cronjobs/overdue_notices.pl +++ b/misc/cronjobs/overdue_notices.pl @@ -41,6 +41,10 @@ use C4::Debug; use C4::Letters; use C4::Overdues qw(GetFine); +use Smart::Comments '####'; + + + =head1 NAME overdue_notices.pl - prepare messages to be sent to patrons for overdue items @@ -677,7 +681,9 @@ sub parse_letter { } my $currency_format; - if ($params->{'letter'}->{'content'} =~ m/(.*)<\/fine>/o) { # process any fine tags... + if ( defined $params->{'letter'}->{'content'} + and $params->{'letter'}->{'content'} =~ m/(.*)<\/fine>/o ) + { # process any fine tags... $currency_format = $1; $params->{'letter'}->{'content'} =~ s/.*<\/fine>/<>/o; } @@ -687,7 +693,7 @@ sub parse_letter { my $item_format = ''; foreach my $item (@$i) { my $fine = GetFine($item->{'itemnumber'}, $params->{'borrowernumber'}); - if (!$item_format) { + if ( !$item_format and defined $params->{'letter'}->{'content'} ) { $params->{'letter'}->{'content'} =~ m/(.*<\/item>)/; $item_format = $1; } -- 1.7.2.5