Bugzilla – Attachment 139971 Details for
Bug 31446
Make it easier for libraries to hide lightbox_descriptions from OPAC lightbox gallery
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31446: Add IDs to parent elements of cover images
Bug-31446-Add-IDs-to-parent-elements-of-cover-imag.patch (text/plain), 2.66 KB, created by
Alex Buckley
on 2022-08-30 04:43:01 UTC
(
hide
)
Description:
Bug 31446: Add IDs to parent elements of cover images
Filename:
MIME Type:
Creator:
Alex Buckley
Created:
2022-08-30 04:43:01 UTC
Size:
2.66 KB
patch
obsolete
>From 695e55c46769ecbb8f16c8517bfed919925101dd Mon Sep 17 00:00:00 2001 >From: Alex Buckley <alexbuckley@catalyst.net.nz> >Date: Tue, 30 Aug 2022 16:18:44 +1200 >Subject: [PATCH] Bug 31446: Add IDs to parent elements of cover images > >Having ID attributes for all parent div tags of OPAC lightbox cover images would >make it easier for libraries to hide the lightbox descriptions hint text >displaying under cover images. > >Libraries could simply add some JavaScript (in a format like below) to their OpacUserJS system preference for each image content source they use: >$("#coce-coverimg > .hint").hide(); > >Test plan: >1. Apply patch >2. Confirm all parent div elements of cover images now have an ID in >opac-detail.tt > >Sponsored-by: Toi Ohomai Institute of Technology, New Zealand >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >index e69c3fac730..9a012e62f5e 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >@@ -63,7 +63,7 @@ > [% IF ( OPACLocalCoverImages ) %] > [% IF localimages.count %] > [% FOREACH image IN localimages %] >- <div class="cover-image local-coverimg"> >+ <div class="cover-image local-coverimg" id="local-coverimg"> > <a href="/cgi-bin/koha/opac-image.pl?imagenumber=[% image.imagenumber | uri %]" title="Local cover image"> > <img src="/cgi-bin/koha/opac-image.pl?thumbnail=1&imagenumber=[% image.imagenumber | uri %]" alt="Local cover image" data-link="/cgi-bin/koha/opac-imageviewer.pl?biblionumber=[% biblionumber | uri %]&imagenumber=[% image.imagenumber | uri %]" /> > </a> >@@ -102,7 +102,7 @@ > > [% IF ( Koha.Preference('OPACCoce') && Koha.Preference('CoceProviders') && normalized_isbn ) %] > [% coce_id = normalized_ean || normalized_isbn %] >- <div class="cover-image coce-coverimg"> >+ <div class="cover-image coce-coverimg" id="coce-coverimg"> > [% IF ( coce_id ) %] > <a title="Image from Coce" class="[% coce_id | html %]" id="coce-thumbnail-preview"></a> > [% END %] >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31446
:
139738
|
139739
|
139971