From 46d1d52aff17d1edbcffa48dd8f6477935047630 Mon Sep 17 00:00:00 2001
From: Aleisha Amohia <aleishaamohia@hotmail.com>
Date: Sun, 1 Jul 2018 23:33:07 +0000
Subject: [PATCH] Bug 7960: Add class to item type descriptions so they can be
 hidden with CSS

This patch adds the class "itypetext" around item type descriptions so
they can easily be hidden with CSS.

To test:
1. Navigate to the pages listed below to confirm that the text
descriptions do show.
2. Add
.itypetext { display:none; }
to IntranetUserCSS and OPACUserCSS system preferences and save.
3. Go back to the pages listed below and confirm that the text
descriptions DO NOT show.

= STAFF CLIENT =
 - catalogue/advsearch.tt
 - catalogue/detail.tt
 - catalogue/results.tt
 - reserve/request.tt
 - virtualshelves/shelves.tt
= OPAC =
 - opac-advsearch.tt
 - opac-detail.tt
 - opac-readingrecord.tt
 - opac-reserve.tt
 - opac-shelves.tt
 - opac-user.tt

Refer to David Nind's test notes from Comment 23 for a more detailed
plan for acessing these pages.

Sponsored-by: Catalyst IT

Signed-off-by: Charles Farmer <charles.farmer@inLibro.com>
---
 koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt    | 2 +-
 koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt       | 8 ++++----
 koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt      | 4 ++--
 koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt        | 2 +-
 koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt | 2 +-
 koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt        | 2 +-
 koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt           | 6 +++---
 koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt    | 4 ++--
 koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt          | 4 ++--
 koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt          | 2 +-
 koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt             | 2 +-
 11 files changed, 19 insertions(+), 19 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt
index 29808258d1..66a579dd33 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt
@@ -214,7 +214,7 @@
                                                         [% END %]
                                                             &nbsp;
                                                     [% END %]
-                                                    [% itemtypeloo.description | html %]
+                                                    <span class="itypetext">[% itemtypeloo.description | html %]</span>
                                                 </label>
                                             </td>
                                             [% IF ( loop.last ) %]
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
index f48413a010..79fb02317b 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
@@ -146,9 +146,9 @@
               <img src="[% imageurl | html %]" alt="" />
           [% END %]
           [% IF ( description ) %]
-            [% description | html %]
+              <span class="itypetext">[% description | html %]</span>
           [% ELSE %]
-            [% itemtype | html %]
+              <span class="itypetext">[% itemtype | html %]</span>
           [% END %]
           </span>
         [% END %]
@@ -401,7 +401,7 @@
                             [% IF !noItemTypeImages && itemtype.image_location %]
                                 <img src="[% itemtype.image_location | html %]" alt="[% itemtype.translated_description | html %]" title="[% itemtype.translated_description | html %]" />
                             [% END %]
-                            <span class="itypedesc">[% itemtype.translated_description | html %]</span>
+                            <span class="itypedesc itypetext">[% itemtype.translated_description | html %]</span>
                         </td>
                     [% END %]
                     <td class="location">[% UNLESS ( singlebranchmode ) %][% Branches.GetName( item.holdingbranch ) | html %] [% END %]</td>
@@ -982,7 +982,7 @@ Note that permanent location is a code, and location may be an authval.
 <div role="tabpanel" class="tab-pane" id="editions"><h4>Editions</h4>
 <table>
 [% FOREACH XISBN IN XISBNS %]<tr>[% IF ( AmazonCoverImages ) %]<td><a href="http://www.amazon.com/gp/reader/[% XISBN.normalized_isbn | uri %][% AmazonAssocTag | uri %]#reader-link"><img src="https://images-na.ssl-images-amazon.com/images/P/[% XISBN.normalized_isbn | html %].01._AA75_PU_PU-5_.jpg" /></a></td>[% END %]
-[% IF ( !item_level_itypes || Koha.Preference('BiblioItemtypeInfo') ) %]<td>[% IF ( noItemTypeImages ) %][% XISBN.description | html %][% ELSE %]<img src="[% XISBN.imageurl | html %]" alt="[% XISBN.description | html %]" title="[% XISBN.description | html %]">[% END %]</td>[% END %]
+[% IF ( !item_level_itypes || Koha.Preference('BiblioItemtypeInfo') ) %]<td>[% IF ( noItemTypeImages ) %]<span class="itypetext">[% XISBN.description | html %]</span>[% ELSE %]<img src="[% XISBN.imageurl | html %]" alt="[% XISBN.description | html %]" title="[% XISBN.description | html %]">[% END %]</td>[% END %]
 <td><a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% XISBN.biblionumber | uri %]">[% XISBN.title | html %]</a> <span>by</span> [% XISBN.author | html %] &copy;[% XISBN.copyrightdate | html %]
   [% IF ( XISBN.publishercode ) %]
 [% XISBN.publishercode | html %] [% IF ( XISBN.place ) %]([% XISBN.place | html %])[% END %] [% IF ( XISBN.publicationyear ) %], [% XISBN.publicationyear | html %][% END %] [% IF ( XISBN.editionstatement ) %][% XISBN.editionstatement | html %][% END %] [% IF ( XISBN.editionresponsibility ) %][% XISBN.editionresponsibility | html %][% END %]
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
index 232099cfb5..16d75b74d9 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
@@ -516,7 +516,7 @@
                                                         [% IF !noItemTypeImages && SEARCH_RESULT.imageurl %]
                                                             <img src="[% SEARCH_RESULT.imageurl | html %]" alt="[%  SEARCH_RESULT.description | html %]" />
                                                         [% END %]
-                                                        [% SEARCH_RESULT.description | html %]
+                                                        <span class="itypetext">[% SEARCH_RESULT.description | html %]</span>
                                                     </div>
                                                 [% END %]
 
@@ -646,7 +646,7 @@
                                                                             [% END %]
 
                                                                             [% IF item_level_itypes && items_loo.description %]
-                                                                                <span class="item-itype-desc">[% items_loo.description | html %]</span>
+                                                                                <span class="item-itype-desc itypetext">[% items_loo.description | html %]</span>
                                                                             [% END %]
                                                                         </li>
                                                                     [% END # /FOREACH other_items_loo %]
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
index eb37dbc00e..9a1c2fa1ea 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
@@ -758,7 +758,7 @@
                                                         [% UNLESS ( noItemTypeImages ) %]
                                                             [% IF ( itemloo.itemtype.image_location) %]<img src="[% itemloo.itemtype.image_location | html %]" alt="" /> <br /> [% END %]
                                                         [% END %]
-                                                        [% itemloo.itemtype.translated_description | html %]
+                                                        <span class="itypetext">[% itemloo.itemtype.translated_description | html %]</span>
                                                     </td>
                                                 [% END %]
                                                 <td>
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt
index 6984b804df..c70ca93a2e 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt
@@ -304,7 +304,7 @@
                 </td>
             [% END %]
 			[% UNLESS ( item_level_itypes ) %]<td>
-                [% UNLESS ( noItemTypeImages || !itemsloo.imageurl ) %]<img src="[% itemsloo.imageurl | html %]" alt="[% itemsloo.description | html %]" title="[% itemsloo.description | html %]" />[% END %][% itemsloo.description | html %]
+                [% UNLESS ( noItemTypeImages || !itemsloo.imageurl ) %]<img src="[% itemsloo.imageurl | html %]" alt="[% itemsloo.description | html %]" title="[% itemsloo.description | html %]" />[% END %]<span class="itypetext">[% itemsloo.description | html %]</span>
 			</td>[% END %]
 			<td>
                 [% IF ( itemsloo.XSLTBloc ) %]
diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
index a7cadb91e1..b9dbe58e23 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
@@ -191,7 +191,7 @@
                                                                     [% END %]
                                                                     &nbsp;
                                                                 [% END %]
-                                                                [% itemtypeloo.description | html %]
+                                                                <span class="itypetext">[% itemtypeloo.description | html %]</span>
                                                             </label>
                                                         </div>
                                                     [% IF ( loop.last ) %]</div>[% ELSE %][% UNLESS ( loop.count % 4 ) %]</div><div class="row">[% END %][% END %]
diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
index e69c3fac73..6bb755d678 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
@@ -171,9 +171,9 @@
                                 <img src="[% imageurl | html %]" alt="" />
                             [% END %]
                             [% IF ( description ) %]
-                                [% description | html %]
+                                <span class="itypetext">[% description | html %]</span>
                             [% ELSE %]
-                                [% itemtype | html %]
+                               <span class="itypetext">[% itemtype | html %]</span>
                             [% END %]
                         </span>
                     [% END %]
@@ -1238,7 +1238,7 @@
                                 <img src="[% ITEM_RESULT.imageurl | html %]" title="[% ITEM_RESULT.description | html %]" alt="[% ITEM_RESULT.description | html %]" />
                             [% END %]
                         [% END %]
-                        [% ITEM_RESULT.description | html %]
+                       <span class="itypetext">[% ITEM_RESULT.description | html %]</span>
                     </td>
                 [% END %]
                 [% IF ( OpacLocationBranchToDisplay == 'holding' || OpacLocationBranchToDisplay == 'both' ) %]
diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt
index 1e4f7d6f3e..acd409bce8 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt
@@ -161,8 +161,8 @@
                                                         <img src="[% issue.imageurl | html %]" alt="" />
                                                     [% END %]
                                                 [% END %]
-                                                <span class="tdlabel">Item type:</span>
-                                                [% issue.translated_description | html %]</td>
+                                                <span class="itypetext"><span class="tdlabel">Item type:</span>
+                                                [% issue.translated_description | html %]</span></td>
                                                 <td>
                                                 <span class="tdlabel">Call number:</span>
                                                 [% issue.itemcallnumber | html %]
diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt
index b45ed20983..12b5064510 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt
@@ -231,7 +231,7 @@
                                                 <li class="itype">
                                                     <span class="label">Item type: </span>
                                                     [% IF ( bibitemloo.imageurl ) %]<img src="[% bibitemloo.imageurl | html %]" alt="" />[% END %]
-                                                    [% bibitemloo.translated_description | html %]
+                                                    <span class="itypetext">[% bibitemloo.translated_description | html %]</span>
                                                 </li>
                                             [% END %]
 
@@ -409,7 +409,7 @@
                                                                             <img src="[% itemLoo.imageurl | html %]" alt="" />
                                                                         [% END %]
                                                                     [% END %]
-                                                                    [% itemLoo.itemtype.translated_description | html %]
+                                                                    <span class="itypetext">[% itemLoo.itemtype.translated_description | html %]</span>
                                                                 </td>
                                                             [% END %]
 
diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
index 37b1b226fd..93a35b7225 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
@@ -399,7 +399,7 @@
                                                             [% UNLESS ( Koha.Preference('OpacNoItemTypeImages') ) %]
                                                                 <img src="[% itemsloo.imageurl | html %]" alt="[% itemsloo.description | html %]" title="[% itemsloo.description | html %]" />
                                                             [% END %]
-                                                            [% itemsloo.description | html %]
+                                                            <span class="itypetext">[% itemsloo.description | html %]</span>
                                                         </td>
                                                     [% END %]
                                                     <td>
diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
index d131abc175..f6f2c7d911 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
@@ -381,7 +381,7 @@
                                                             <span class="tdlabel">Item type:</span>
                                                             [% IF ( ISSUE.imageurl && !Koha.Preference('OpacNoItemTypeImages') ) %]
                                                                 <img src="[% ISSUE.imageurl | html %]" title="[% ISSUE.description | html %]" alt="[% ISSUE.description | html %]" />
-                                                            [% END %] [% ISSUE.description | html %]
+                                                                [% END %] <span class="itypetext">[% ISSUE.description | html %]</span>
                                                         </td>
                                                     [% END %]
                                                     [% IF ( show_barcode ) %]
-- 
2.11.0