Bugzilla – Attachment 140402 Details for
Bug 31486
Deleting a message from checkouts tab redirects to detail tab in patron account
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31486: Redirect to proper page after message deletion
Bug-31486-Redirect-to-proper-page-after-message-de.patch (text/plain), 2.90 KB, created by
Katrin Fischer
on 2022-09-11 14:16:18 UTC
(
hide
)
Description:
Bug 31486: Redirect to proper page after message deletion
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2022-09-11 14:16:18 UTC
Size:
2.90 KB
patch
obsolete
>From fb120de216898c18dd24cef37fa04b15eb117c47 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Mon, 29 Aug 2022 21:48:01 +0000 >Subject: [PATCH] Bug 31486: Redirect to proper page after message deletion > >To test: >1. Go to a patron account and create some messages >2. Try deleting some from both the patron details page and the patron checkout page. >3. Notice that is you are on the patron checkout page and delete a message you are then redirected to the patron details page. >4. Apply patch >5. Try deleting messages from both pages and confirm you are redirected back to that same page and the message is properly deleted. > >Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc | 4 ++++ > koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt | 2 +- > 2 files changed, 5 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc >index cb99f267e7..7d629a5534 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc >@@ -310,7 +310,11 @@ > <em>"[% patron_message.message | html %]"</em> > </span> > [% IF patron_message.branchcode == Branches.GetLoggedInBranchcode OR Koha.Preference('AllowAllMessageDeletion') %] >+ [% IF moremember %] > <a class="btn btn-link delete_message" href="/cgi-bin/koha/circ/del_message.pl?message_id=[% patron_message.message_id | html %]&borrowernumber=[% patron_message.borrowernumber | html %]&from=moremember"><i class="fa fa-trash"></i> Delete</a> >+ [% ELSE %] >+ <a class="btn btn-link delete_message" href="/cgi-bin/koha/circ/del_message.pl?message_id=[% patron_message.message_id | html %]&borrowernumber=[% patron_message.borrowernumber | html %]"><i class="fa fa-trash"></i> Delete</a> >+ [% END %] > [% END %] > </li> > [% END %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt >index 2dda38be50..ac4ad7e375 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt >@@ -92,7 +92,7 @@ > [% END %] > > <div id="patron_messages" class="circmessage attention"> >- [% INCLUDE 'patron_messages.inc' %] >+ [% INCLUDE 'patron_messages.inc' moremember = 1 %] > </div> > > <h1>[% INCLUDE 'patron-title.inc' no_html = 1 %]</h1> >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31486
:
139967
|
140309
| 140402