Bugzilla – Attachment 140474 Details for
Bug 26247
Search terms retained in header search creates UX inconsistency
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 26247: (QA follow-up) Merge DB Updates
Bug-26247-QA-follow-up-Merge-DB-Updates.patch (text/plain), 3.47 KB, created by
Martin Renvoize
on 2022-09-12 16:10:33 UTC
(
hide
)
Description:
Bug 26247: (QA follow-up) Merge DB Updates
Filename:
MIME Type:
Creator:
Martin Renvoize
Created:
2022-09-12 16:10:33 UTC
Size:
3.47 KB
patch
obsolete
>From 60f768c14471e2150ad3d525a9d189ccd85c6598 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Mon, 12 Sep 2022 17:09:24 +0100 >Subject: [PATCH] Bug 26247: (QA follow-up) Merge DB Updates > >--- > ...26247-add_RetainCatalogSearchTerms_syspref.pl | 12 ------------ > ...26247-add_RetainPatronsSearchTerms_syspref.pl | 12 ------------ > installer/data/mysql/atomicupdate/bug_26247.pl | 16 ++++++++++++++++ > 3 files changed, 16 insertions(+), 24 deletions(-) > delete mode 100755 installer/data/mysql/atomicupdate/bug_26247-add_RetainCatalogSearchTerms_syspref.pl > delete mode 100755 installer/data/mysql/atomicupdate/bug_26247-add_RetainPatronsSearchTerms_syspref.pl > create mode 100644 installer/data/mysql/atomicupdate/bug_26247.pl > >diff --git a/installer/data/mysql/atomicupdate/bug_26247-add_RetainCatalogSearchTerms_syspref.pl b/installer/data/mysql/atomicupdate/bug_26247-add_RetainCatalogSearchTerms_syspref.pl >deleted file mode 100755 >index 44637ca774..0000000000 >--- a/installer/data/mysql/atomicupdate/bug_26247-add_RetainCatalogSearchTerms_syspref.pl >+++ /dev/null >@@ -1,12 +0,0 @@ >-use Modern::Perl; >- >-return { >- bug_number => "26247", >- description => "Add new system preference RetainCatalogSearchTerms", >- up => sub { >- my ($args) = @_; >- my ($dbh, $out) = @$args{qw(dbh out)}; >- >- $dbh->do(q{INSERT IGNORE INTO systempreferences (variable,value,options,explanation,type) VALUES ('RetainCatalogSearchTerms', '1', NULL, 'If enabled, searches entered into the catalog search bar will be retained', 'YesNo') }); >- }, >-}; >diff --git a/installer/data/mysql/atomicupdate/bug_26247-add_RetainPatronsSearchTerms_syspref.pl b/installer/data/mysql/atomicupdate/bug_26247-add_RetainPatronsSearchTerms_syspref.pl >deleted file mode 100755 >index dd6d842fa6..0000000000 >--- a/installer/data/mysql/atomicupdate/bug_26247-add_RetainPatronsSearchTerms_syspref.pl >+++ /dev/null >@@ -1,12 +0,0 @@ >-use Modern::Perl; >- >-return { >- bug_number => "26247", >- description => "Add new system preference RetainPatronsSearchTerms", >- up => sub { >- my ($args) = @_; >- my ($dbh, $out) = @$args{qw(dbh out)}; >- >- $dbh->do(q{INSERT IGNORE INTO systempreferences (variable,value,options,explanation,type) VALUES ('RetainPatronSearchTerms', '1', NULL, 'If enabled, searches entered into the checkout and patrons search bars will be retained', 'YesNo') }); >- }, >-}; >diff --git a/installer/data/mysql/atomicupdate/bug_26247.pl b/installer/data/mysql/atomicupdate/bug_26247.pl >new file mode 100644 >index 0000000000..439f136c75 >--- /dev/null >+++ b/installer/data/mysql/atomicupdate/bug_26247.pl >@@ -0,0 +1,16 @@ >+use Modern::Perl; >+ >+return { >+ bug_number => "26247", >+ description => "Add new retain search terms preferences", >+ up => sub { >+ my ($args) = @_; >+ my ($dbh, $out) = @$args{qw(dbh out)}; >+ >+ $dbh->do(q{INSERT IGNORE INTO systempreferences (variable,value,options,explanation,type) VALUES ('RetainCatalogSearchTerms', '1', NULL, 'If enabled, searches entered into the catalog search bar will be retained', 'YesNo') }); >+ say $out "Added `RetainCatalogSearchTerms` preference"; >+ >+ $dbh->do(q{INSERT IGNORE INTO systempreferences (variable,value,options,explanation,type) VALUES ('RetainPatronSearchTerms', '1', NULL, 'If enabled, searches entered into the checkout and patrons search bars will be retained', 'YesNo') }); >+ say $out "Added `RetainPatronsSearchTerms` preference"; >+ }, >+}; >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 26247
:
117408
|
117409
|
117410
|
117411
|
117461
|
117535
|
117536
|
117537
|
117538
|
117539
|
120353
|
120354
|
120355
|
120356
|
120357
|
120358
|
120359
|
120360
|
136683
|
136767
|
137310
|
138478
|
140473
| 140474