From 223cbfaf2b32f76baf95dabba9403942bddaa596 Mon Sep 17 00:00:00 2001
From: Nick Clemens <nick@bywatersolutions.com>
Date: Tue, 2 Nov 2021 11:57:21 +0000
Subject: [PATCH] Bug 29389: Add holding branch to the holds queue report

This patch adds the holding branch to the hold queue report.
It is added as hidden by default, when running per branch it is not needed

To test:
 1 - Place some holds in your system
 2 - perl misc/cronjobs/holds/build_holdsqueue.pl
 3 - View the holds queue
 4 - Note there is no 'Current library' column
 5 - Apply patch
 6 - Reload
 7 - Note the column is not there
 8 - Click column setting gear
 9 - Check the column and confirm it appears
10 - Confirm the filter works
---
 admin/columns_settings.yml                                 | 3 +++
 .../intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt  | 7 +++++++
 2 files changed, 10 insertions(+)

diff --git a/admin/columns_settings.yml b/admin/columns_settings.yml
index 1b27cb60f1..59b0b0009a 100644
--- a/admin/columns_settings.yml
+++ b/admin/columns_settings.yml
@@ -1374,6 +1374,9 @@ modules:
       holds-table:
         default_sort_order: 3
         columns:
+            -
+              columnname: holdingbranch
+              is_hidden: 1
             -
               columnname: title
             -
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt
index 7d1032386c..8c04364f6b 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt
@@ -76,6 +76,7 @@
 <table id="holdst">
 	<thead>
     <tr>
+        <th class="hq-holdingbranch">Holdingbranch</th>
         <th class="hq-title anti-the">Title</th>
         <th class="hq-collection">Collection</th>
         <th class="hq-itemtype">Item type</th>
@@ -90,6 +91,11 @@
         <th class="hq-notes">Notes</th>
     </tr>
     <tr>
+        <td class="hq-holdingbranch">
+            <span class="filter_column filter_text">
+                <input class="text_filter" type="text" placeholder="Holding branch">
+            </span>
+        </td>
         <td class="hq-title">
             <span class="filter_column filter_text">
                 <input class="text_filter" type="text" placeholder="Title">
@@ -154,6 +160,7 @@
 	</thead>
      <tbody>[% FOREACH itemsloo IN itemsloop %]
         <tr>
+            <td class="hq-holdingbranch">[% Branches.GetName( itemsloo.holdingbranch ) | html %]</td>
             <td class="hq-title">
                 <p>
                     [% INCLUDE 'biblio-title.inc' biblio=itemsloo link = 1 %]
-- 
2.30.2