Bugzilla – Attachment 140864 Details for
Bug 29561
Remove blank facet for languages
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29561: (follow-up) Don't remove facet '0'
Bug-29561-follow-up-Dont-remove-facet-0.patch (text/plain), 1.23 KB, created by
Nick Clemens
on 2022-09-22 19:54:55 UTC
(
hide
)
Description:
Bug 29561: (follow-up) Don't remove facet '0'
Filename:
MIME Type:
Creator:
Nick Clemens
Created:
2022-09-22 19:54:55 UTC
Size:
1.23 KB
patch
obsolete
>From 2e4124af984b35e7ea2abc53cd8d6dfd8f107d4c Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Thu, 22 Sep 2022 19:54:07 +0000 >Subject: [PATCH] Bug 29561: (follow-up) Don't remove facet '0' > >--- > Koha/SearchEngine/Elasticsearch/Search.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/Koha/SearchEngine/Elasticsearch/Search.pm b/Koha/SearchEngine/Elasticsearch/Search.pm >index be31f50712..e8e4412b56 100644 >--- a/Koha/SearchEngine/Elasticsearch/Search.pm >+++ b/Koha/SearchEngine/Elasticsearch/Search.pm >@@ -492,7 +492,7 @@ sub _convert_facets { > $limit = @{ $data->{buckets} } if ( $limit > @{ $data->{buckets} } ); > foreach my $term ( @{ $data->{buckets} }[ 0 .. $limit - 1 ] ) { > my $t = $term->{key}; >- next unless $t; # FIXME Currently we cannot search for an empty faceted field i.e. ln:"" to find records missing languages, though ES does count them correctly >+ next unless length($t); # FIXME Currently we cannot search for an empty faceted field i.e. ln:"" to find records missing languages, though ES does count them correctly > my $c = $term->{doc_count}; > my $label; > if ( exists( $special{$type} ) ) { >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29561
:
127957
|
128100
|
129595
|
140862
|
140863
|
140864
|
141543
|
141544
|
141545