From daaeca704c5f064029b215e7b601cfe93cf3c5e4 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Thu, 22 Sep 2022 15:48:32 +0000 Subject: [PATCH] Bug 31605: Improve style of OPAC suggestions search form This patch makes minor modifications to the markup for the OPAC suggestions search form so that the different labels and form fields display a little more nicely. The patch also adds standard Bootstrap alert classes to several messages which might be displayed on the screen, e.g. "You have no pending purchase suggestions." To test, apply the patch and make sure the "suggestion" system preference is enabled. - With the OPACViewOthersSuggestions preference disabled, log in to the OPAC and view your suggestions. - If you have no suggestions you should see a Bootstrap-styled message box, "You have no pending purchase suggestions." - If necessary, submit a suggestion. With at least one suggestion present you should see a search form above the table of suggestions. The label, form field, and submit button should line up nicely. - Test that the search form works correctly to find suggestions in your system. - If you search for a suggestion which doesn't exist you should see a message-style alert, "There are no pending purchase suggestions matching your search." - Enable the OPACViewOthersSuggestions system preference. - Return to the OPAC suggestions page. The form field should now include a nicely-styled "Suggested by" filter. Signed-off-by: George Williams Signed-off-by: Lucas Gass --- .../bootstrap/en/modules/opac-suggestions.tt | 20 +++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt index 576178db7d..c173a2729b 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt @@ -313,8 +313,12 @@ [% SET can_delete_suggestion = 0 %]
- - +
+ +
+
+ +
[% IF Koha.Preference( 'OPACViewOthersSuggestions' ) == 1 %] [% IF loggedinusername %]
@@ -460,21 +464,21 @@ [% ELSE %] [% IF Koha.Preference( 'OPACViewOthersSuggestions' ) %] [% IF title_filter %] -

There are no pending purchase suggestions matching your search.

+ [% ELSIF loggedinusername AND NOT suggested_by_anyone %] -

You have no pending purchase suggestions. View all suggestions

+ [% ELSE %] -

There are no pending purchase suggestions.

+ [% END %] [% ELSE %] [% IF ( loggedinusername ) %] [% IF title_filter %] -

There are no pending purchase suggestions matching your search.

+ [% ELSE %] -

You have no pending purchase suggestions.

+ [% END %] [% ELSE %] -

You are not authorized to see pending purchase suggestions.

+ [% END %] [% END %] [% IF ( loggedinusername || ( Koha.Preference( 'AnonSuggestions' ) == 1 ) ) %] -- 2.30.2