From 44b2d1b12d6f54220c847699369e66e004e6b53f Mon Sep 17 00:00:00 2001
From: Nick Clemens <nick@bywatersolutions.com>
Date: Fri, 30 Sep 2022 12:32:25 +0000
Subject: [PATCH] Bug 27265: (follow-up) Use existing parameter

---
 C4/Letters.pm | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/C4/Letters.pm b/C4/Letters.pm
index 87d7e36161..8edaa63ccc 100644
--- a/C4/Letters.pm
+++ b/C4/Letters.pm
@@ -976,7 +976,7 @@ sub SendQueuedMessages {
         'limit'          => $params->{'limit'} // 0,
         'borrowernumber' => $params->{'borrowernumber'} // q{},
         'letter_code'    => $params->{'letter_code'} // q{},
-        'type'           => $params->{'type'} // q{},
+        'message_transport_type'           => $params->{'type'} // q{},
     };
     my $unsent_messages = _get_unsent_messages( $which_unsent_messages );
     MESSAGE: foreach my $message ( @$unsent_messages ) {
@@ -1256,10 +1256,6 @@ sub _get_unsent_messages {
 
     my @query_params = ('pending');
     if ( ref $params ) {
-        if ( $params->{'message_transport_type'} ) {
-            $statement .= ' AND mq.message_transport_type = ? ';
-            push @query_params, $params->{'message_transport_type'};
-        }
         if ( $params->{'borrowernumber'} ) {
             $statement .= ' AND mq.borrowernumber = ? ';
             push @query_params, $params->{'borrowernumber'};
@@ -1272,8 +1268,8 @@ sub _get_unsent_messages {
                 push @query_params, @letter_codes;
             }
         }
-        if ( $params->{'type'} ) {
-            my @types = ref $params->{'type'} eq "ARRAY" ? @{$params->{'type'}} : $params->{'type'};
+        if ( $params->{'message_transport_type'} ) {
+            my @types = ref $params->{'message_transport_type'} eq "ARRAY" ? @{$params->{'message_transport_type'}} : $params->{'message_transport_type'};
             if ( @types ) {
                 my $q = join( ",", ("?") x @types );
                 $statement .= " AND message_transport_type IN ( $q ) ";
-- 
2.30.2