From 038ff28ef9cbda5fd123554d2cb3efd155ba9486 Mon Sep 17 00:00:00 2001 From: Aleisha Amohia Date: Sun, 1 Jul 2018 23:33:07 +0000 Subject: [PATCH] Bug 7960: Add class to item type descriptions so they can be hidden with CSS This patch adds the class "itypetext" around item type descriptions so they can easily be hidden with CSS. To test: 1. Navigate to the pages listed below to confirm that the text descriptions do show. 2. Add .itypetext { display:none; } to IntranetUserCSS and OPACUserCSS system preferences and save. 3. Go back to the pages listed below and confirm that the text descriptions DO NOT show. = STAFF CLIENT = - catalogue/advsearch.tt - catalogue/detail.tt - catalogue/results.tt - reserve/request.tt - virtualshelves/shelves.tt = OPAC = - opac-advsearch.tt - opac-detail.tt - opac-readingrecord.tt - opac-reserve.tt - opac-shelves.tt - opac-user.tt Refer to David Nind's test notes from Comment 23 for a more detailed plan for acessing these pages. Sponsored-by: Catalyst IT Signed-off-by: Charles Farmer Signed-off-by: David Nind Signed-off-by: Katrin Fischer --- .../intranet-tmpl/prog/en/modules/catalogue/advsearch.tt | 2 +- .../intranet-tmpl/prog/en/modules/catalogue/detail.tt | 8 ++++---- .../intranet-tmpl/prog/en/modules/catalogue/results.tt | 4 ++-- .../intranet-tmpl/prog/en/modules/reserve/request.tt | 2 +- .../prog/en/modules/virtualshelves/shelves.tt | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-advsearch.tt | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 6 +++--- .../opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt | 4 ++-- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt | 4 ++-- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt | 2 +- 11 files changed, 19 insertions(+), 19 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt index 29808258d1..66a579dd33 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt @@ -214,7 +214,7 @@ [% END %]   [% END %] - [% itemtypeloo.description | html %] + [% itemtypeloo.description | html %] [% IF ( loop.last ) %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt index f48413a010..79fb02317b 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt @@ -146,9 +146,9 @@ [% END %] [% IF ( description ) %] - [% description | html %] + [% description | html %] [% ELSE %] - [% itemtype | html %] + [% itemtype | html %] [% END %] [% END %] @@ -401,7 +401,7 @@ [% IF !noItemTypeImages && itemtype.image_location %] [% itemtype.translated_description | html %] [% END %] - [% itemtype.translated_description | html %] + [% itemtype.translated_description | html %] [% END %] [% UNLESS ( singlebranchmode ) %][% Branches.GetName( item.holdingbranch ) | html %] [% END %] @@ -982,7 +982,7 @@ Note that permanent location is a code, and location may be an authval.

Editions

[% FOREACH XISBN IN XISBNS %][% IF ( AmazonCoverImages ) %][% END %] -[% IF ( !item_level_itypes || Koha.Preference('BiblioItemtypeInfo') ) %][% END %] +[% IF ( !item_level_itypes || Koha.Preference('BiblioItemtypeInfo') ) %][% END %] [% END %] [% END %] [% END %] [% IF ( OpacLocationBranchToDisplay == 'holding' || OpacLocationBranchToDisplay == 'both' ) %] diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt index 1e4f7d6f3e..acd409bce8 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt @@ -161,8 +161,8 @@ [% END %] [% END %] - Item type: - [% issue.translated_description | html %] + Item type: + [% issue.translated_description | html %] [% END %] diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt index 37b1b226fd..93a35b7225 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt @@ -399,7 +399,7 @@ [% UNLESS ( Koha.Preference('OpacNoItemTypeImages') ) %] [% itemsloo.description | html %] [% END %] - [% itemsloo.description | html %] + [% itemsloo.description | html %] [% END %] [% END %] [% IF ( show_barcode ) %] -- 2.30.2
[% IF ( noItemTypeImages ) %][% XISBN.description | html %][% ELSE %][% XISBN.description | html %][% END %][% IF ( noItemTypeImages ) %][% XISBN.description | html %][% ELSE %][% XISBN.description | html %][% END %][% XISBN.title | html %] by [% XISBN.author | html %] ©[% XISBN.copyrightdate | html %] [% IF ( XISBN.publishercode ) %] [% XISBN.publishercode | html %] [% IF ( XISBN.place ) %]([% XISBN.place | html %])[% END %] [% IF ( XISBN.publicationyear ) %], [% XISBN.publicationyear | html %][% END %] [% IF ( XISBN.editionstatement ) %][% XISBN.editionstatement | html %][% END %] [% IF ( XISBN.editionresponsibility ) %][% XISBN.editionresponsibility | html %][% END %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt index 152c7b8335..03e9f5e1a5 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt @@ -516,7 +516,7 @@ [% IF !noItemTypeImages && SEARCH_RESULT.imageurl %] [% SEARCH_RESULT.description | html %] [% END %] - [% SEARCH_RESULT.description | html %] + [% SEARCH_RESULT.description | html %] [% END %] @@ -645,7 +645,7 @@ [% END %] [% IF item_level_itypes && items_loo.description %] - [% items_loo.description | html %] + [% items_loo.description | html %] [% END %] [% END # /FOREACH other_items_loo %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt index 0ed253f766..4b41833bda 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt @@ -758,7 +758,7 @@ [% UNLESS ( noItemTypeImages ) %] [% IF ( itemloo.itemtype.image_location) %]
[% END %] [% END %] - [% itemloo.itemtype.translated_description | html %] + [% itemloo.itemtype.translated_description | html %] 		diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt index cb62f8cf1c..e5a9db973f 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt @@ -327,7 +327,7 @@ [% UNLESS ( noItemTypeImages || !itemsloo.imageurl ) %] [% itemsloo.description | html %] [% END %] - [% itemsloo.description | html %] + [% itemsloo.description | html %] diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt index a7cadb91e1..b9dbe58e23 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt @@ -191,7 +191,7 @@ [% END %]   [% END %] - [% itemtypeloo.description | html %] + [% itemtypeloo.description | html %] [% IF ( loop.last ) %][% ELSE %][% UNLESS ( loop.count % 4 ) %]
[% END %][% END %] diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt index 319d584cd9..d4e7f94c80 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt @@ -171,9 +171,9 @@ [% END %] [% IF ( description ) %] - [% description | html %] + [% description | html %] [% ELSE %] - [% itemtype | html %] + [% itemtype | html %] [% END %] [% END %] @@ -1238,7 +1238,7 @@ [% ITEM_RESULT.description | html %] [% END %] [% END %] - [% ITEM_RESULT.description | html %] + [% ITEM_RESULT.description | html %]
Call number: [% issue.itemcallnumber | html %] diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt index a43b084032..ac5f1ccd8c 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt @@ -231,7 +231,7 @@
  • Item type: [% IF ( bibitemloo.imageurl ) %][% END %] - [% bibitemloo.translated_description | html %] + [% bibitemloo.translated_description | html %]
    • [% END %] @@ -406,7 +406,7 @@ [% END %] [% END %] - [% itemLoo.itemtype.translated_description | html %] + [% itemLoo.itemtype.translated_description | html %]     		diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt index d131abc175..f6f2c7d911 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt @@ -381,7 +381,7 @@ Item type: [% IF ( ISSUE.imageurl && !Koha.Preference('OpacNoItemTypeImages') ) %] [% ISSUE.description | html %] - [% END %] [% ISSUE.description | html %] + [% END %] [% ISSUE.description | html %]