From cda6293fd70226a20866ff93e8ead728596cea9a Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Mon, 22 Nov 2021 13:00:57 +0000 Subject: [PATCH] Bug 29554: Do not hide display of itemtypes on neworderempty Hiding the list may lead to biblioitems.itemtype being NULL. We do not want that, since 942$c is mandatory. Test plan: Create basket and set 'create items when' to receiving or cataloging. Create order from new empty record. Check biblioitems.itemtype of created biblio. Without this patch, it would have been NULL like this: select biblionumber,title from biblio; | 7 | Test 3 | select biblionumber,itemtype from biblioitems; | 7 | NULL | Signed-off-by: Marcel de Rooy Signed-off-by: David Nind Signed-off-by: Martin Renvoize --- acqui/neworderempty.pl | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/acqui/neworderempty.pl b/acqui/neworderempty.pl index e4f8a9f175..a584ea1d11 100755 --- a/acqui/neworderempty.pl +++ b/acqui/neworderempty.pl @@ -364,9 +364,7 @@ if ($basketobj->effective_create_items eq 'ordering' && !$ordernumber) { ); } -# Get the item types list, but only if item_level_itype is YES. Otherwise, it will be in the item, no need to display it in the biblio -my @itemtypes; -@itemtypes = Koha::ItemTypes->search->as_list unless C4::Context->preference('item-level_itypes'); +my @itemtypes = Koha::ItemTypes->search->as_list; if ( defined $from_subscriptionid ) { # Get the last received order for this subscription -- 2.20.1