From c6f51d635ba60ff352e6a5355957c51a166db835 Mon Sep 17 00:00:00 2001 From: Lari Taskula Date: Tue, 18 Oct 2022 22:38:36 +0000 Subject: [PATCH] Bug 31692: (alternative look) Use select dropdown --- .../prog/en/includes/holds_table.inc | 17 +++++++++++--- koha-tmpl/intranet-tmpl/prog/js/holds.js | 23 ------------------- 2 files changed, 14 insertions(+), 26 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc index ca59beeb2d..a379d41816 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc @@ -166,6 +166,7 @@ [%- ELSE -%] [%- IF ( hold.item_level_hold ) -%] + [%- IF ! hold.change_hold_type_allowed -%] Only item [%- IF ( hold.barcodenumber ) -%] @@ -175,14 +176,24 @@ No barcode [%- END -%] - [%- IF hold.change_hold_type_allowed -%] + [%- ELSE -%] + + [%- IF ( hold.barcodenumber ) -%] + + [%- END -%] [%- IF hold.itemtype -%] Next available [% ItemTypes.GetDescription( hold.itemtype ) | html %] item [%- ELSE -%] Next available [%- END -%] - - [%- END -%] [%- ELSE -%] diff --git a/koha-tmpl/intranet-tmpl/prog/js/holds.js b/koha-tmpl/intranet-tmpl/prog/js/holds.js index cc9036fb6d..58ecb622c2 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/holds.js +++ b/koha-tmpl/intranet-tmpl/prog/js/holds.js @@ -441,27 +441,4 @@ $(document).ready(function() { window.location.href='request.pl?action=toggleSuspend&reserve_id=' + reserve_id + '&biblionumber=' + biblionumber + '&suspend_until=' + suspend_until; return false; }); - - $("a#change_hold_type_icon").on('click', function(e) { - e.preventDefault(); - let reserve_id = $(this).data('reserve-id'); - let change_type = $("input#change_hold_type_" + reserve_id).val(); - let only_item = $(this).siblings("span:first"); - let only_itemlink = $(this).siblings("a:first"); - let next_available = $(this).siblings("span:last"); - if (change_type==="1") { - $("input#change_hold_type_" + reserve_id).val("0"); - next_available.hide(); - only_itemlink.show(); - only_item.show(); - $(this).removeClass("fa-chain").addClass("fa-chain-broken"); - } else { - $("input#change_hold_type_" + reserve_id).val("1"); - only_itemlink.hide(); - only_item.hide(); - next_available.show(); - $(this).removeClass("fa-chain-broken").addClass("fa-chain"); - } - return false; - }); }); -- 2.25.1