From ec74ecc9831176b307d391ba9136587fd56936cb Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Tue, 4 Dec 2012 16:56:54 +0100 Subject: [PATCH] Bug 9140: Followup removes the useless variable $message Signed-off-by: Kyle M Hall Signed-off-by: Paul Poulain --- circ/bookcount.pl | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/circ/bookcount.pl b/circ/bookcount.pl index 8405ff2..75bf319 100755 --- a/circ/bookcount.pl +++ b/circ/bookcount.pl @@ -45,12 +45,11 @@ my $data = GetBiblioItemData($bi); my $homebranch = $branches->{ $idata->{'homebranch'} }->{'branchname'}; my $holdingbranch = $branches->{ $idata->{'holdingbranch'} }->{'branchname'}; -my ( $lastmove, $message ) = lastmove($itm); +my $lastmove = lastmove($itm); my $lastdate; my $count; if ( not $lastmove ) { -# $lastdate = $message; $count = issuessince( $itm, 0 ); } else { $lastdate = $lastmove->{'datearrived'}; @@ -79,8 +78,6 @@ foreach (@$branchloop) { $_->{seentime} = $timechunk; } -### $lastdate - $template->param( biblionumber => $biblionumber, title => $data->{'title'}, @@ -112,14 +109,14 @@ sub lastmove { ); $sth->execute($itemnumber); my ($date) = $sth->fetchrow_array; - return ( 0, 1 ) if not $date; + return 0 unless $date; $sth = $dbh->prepare( "SELECT * FROM branchtransfers WHERE branchtransfers.itemnumber=? and branchtransfers.datearrived=?" ); $sth->execute( $itemnumber, $date ); my ($data) = $sth->fetchrow_hashref; - return ( 0, 1 ) if not $data; - return ( $data, "" ); + return 0 unless $data; + return $data; } sub issuessince { @@ -165,7 +162,7 @@ sub lastseenat { "SELECT MAX(transfer) FROM (SELECT max(datearrived) AS transfer FROM branchtransfers WHERE itemnumber=? AND tobranch = ? UNION ALL SELECT max(datesent) AS transfer FROM branchtransfers WHERE itemnumber=? AND frombranch = ? - ) tmp" + ) tmp" ); $sth->execute( $itm, $brc, $itm, $brc ); my ($date2) = $sth->fetchrow_array; @@ -179,7 +176,6 @@ sub lastseenat { sub slashdate { my ($date) = @_; $date or return; - # warn "slashdate($date)..."; return ( format_date($date), substr($date,11,5) -- 1.7.9.5