From 5784504b84d36e5ce3d975755e08c1c1005ce2f5 Mon Sep 17 00:00:00 2001 From: Kyle Hall Date: Tue, 15 Mar 2022 11:38:51 -0400 Subject: [PATCH] Bug 20817: (QA follow-up) Fix POD for GetMarcFieldsToOrderValues and GetMarcItemFieldsToOrderValues --- Koha/Acquisition/Utils.pm | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/Koha/Acquisition/Utils.pm b/Koha/Acquisition/Utils.pm index b78be6401f..c898a00f38 100644 --- a/Koha/Acquisition/Utils.pm +++ b/Koha/Acquisition/Utils.pm @@ -31,12 +31,9 @@ Koha::Acquisition::Utils - Additional Koha functions for dealing with orders and my $data = Koha::Acquisition::Utils::GetMarcFieldsToOrderValues('MarcFieldsToOrder', $marcrecord, ['price', 'quantity', 'budget_code', etc.]); -This subroutine accepts a syspref ( MarcFieldsToOrder ), -a marc record, and an arrayref of fields to retrieve. - The return value is a hashref of key value pairs, where the keys are the field list parameters, and the values are extracted from the MARC record based on the key to MARC field mapping from the -given system preference. +system preference MarcFieldsToOrder. =cut @@ -71,12 +68,9 @@ sub GetMarcFieldsToOrderValues { my $data = GetMarcItemFieldsToOrderValues('MarcItemFieldsToOrder', $marcrecord, ['homebranch', 'holdingbranch', 'itype', 'nonpublic_note', 'public_note', 'loc', 'ccode', 'notforloan', 'uri', 'copyno', 'price', 'replacementprice', 'itemcallnumber', 'quantity', 'budget_code']); -This subroutine accepts a syspref ( MarcItemFieldsToOrder ), -a marc record, and an arrayref of fields to retrieve. - The return value is a hashref of key value pairs, where the keys are the field list parameters, and the values are extracted from the MARC record based on the key to MARC field mapping from the -given system preference. +system preference MarcFieldsToOrder. The largest difference between GetMarcFieldsToOrderValues and GetMarcItemFieldsToOrderValues is that the former deals with singular marc fields, while the latter works on multiple matching marc fields and returns -1 if it cannot -- 2.30.2