Bugzilla – Attachment 142649 Details for
Bug 20817
Add ability to retain 9xx fields when adding on order item to existing record
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20817: (QA follow-up) Fix _trim
Bug-20817-QA-follow-up-Fix-trim.patch (text/plain), 918 bytes, created by
Kyle M Hall
on 2022-10-25 16:42:04 UTC
(
hide
)
Description:
Bug 20817: (QA follow-up) Fix _trim
Filename:
MIME Type:
Creator:
Kyle M Hall
Created:
2022-10-25 16:42:04 UTC
Size:
918 bytes
patch
obsolete
>From 0ecb35cbb6c133f0ba36344ef9195ef5d6451776 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Thu, 15 Jul 2021 12:50:35 +0000 >Subject: [PATCH] Bug 20817: (QA follow-up) Fix _trim > >The patch 'trim should always return a value' does not completely >do the job yet. And might have unwanted effects for the '0' case. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > acqui/neworderempty.pl | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > >diff --git a/acqui/neworderempty.pl b/acqui/neworderempty.pl >index 01e43f972f..0ffb1eed29 100755 >--- a/acqui/neworderempty.pl >+++ b/acqui/neworderempty.pl >@@ -697,10 +697,8 @@ sub staged_items_field { > return (\%cellrecord); > } > >- > sub _trim { >- my $string = shift; >- return unless $string; >+ my $string = shift // q{}; > $string =~ s/^\s+|\s+$//g; >- return $string // q{}; >+ return $string; > } >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20817
:
79867
|
80537
|
86711
|
86746
|
105214
|
105215
|
105216
|
105217
|
105218
|
105219
|
115343
|
118371
|
118372
|
118373
|
118374
|
118375
|
118376
|
118377
|
118378
|
122692
|
122834
|
122841
|
122858
|
122861
|
128766
|
128767
|
128768
|
128769
|
128770
|
128771
|
128772
|
128773
|
128774
|
128775
|
128776
|
128777
|
128782
|
128783
|
128785
|
128786
|
128787
|
128788
|
128789
|
128790
|
128791
|
128792
|
128793
|
128794
|
128795
|
128796
|
128797
|
128798
|
131732
|
131733
|
131734
|
131735
|
131736
|
131737
|
131738
|
131739
|
131740
|
131741
|
131742
|
131743
|
131744
|
131745
|
131746
|
131747
|
131748
|
131749
|
142630
|
142631
|
142632
|
142633
|
142634
|
142635
|
142636
|
142637
|
142638
|
142639
|
142640
|
142641
|
142642
|
142643
|
142644
|
142645
|
142646
|
142647
|
142648
|
142649
|
142650
|
142651
|
142829