Bugzilla – Attachment 142653 Details for
Bug 24387
Rename News tool
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24387 - fixup to db_rev for non-english, multilingual Koha
Bug-24387---fixup-to-dbrev-for-non-english-multili.patch (text/plain), 2.22 KB, created by
Blou
on 2022-10-25 19:03:03 UTC
(
hide
)
Description:
Bug 24387 - fixup to db_rev for non-english, multilingual Koha
Filename:
MIME Type:
Creator:
Blou
Created:
2022-10-25 19:03:03 UTC
Size:
2.22 KB
patch
obsolete
>From 559376aaf1c53efa1589a37e77769c6ffc41088d Mon Sep 17 00:00:00 2001 >From: Blou <blou@inlibro.com> >Date: Tue, 25 Oct 2022 14:55:52 -0400 >Subject: [PATCH] Bug 24387 - fixup to db_rev for non-english, multilingual > Koha > >Without this patch, the update process duplicates all the news and >content entries when they were non-english to start with. > >This patch keeps the same process, but new "default" "parent" entries are empty so there' >no duplication in the OPAC display, while still being editable/deletable >in the intranet. > >We came through that through many iterations. This was the least >invasive while still providing satisfying results. >--- > installer/data/mysql/db_revs/210600016.pl | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/installer/data/mysql/db_revs/210600016.pl b/installer/data/mysql/db_revs/210600016.pl >index 8d66de86cb..6d03adc89d 100755 >--- a/installer/data/mysql/db_revs/210600016.pl >+++ b/installer/data/mysql/db_revs/210600016.pl >@@ -111,7 +111,7 @@ return { > # Now this is getting weird > # We are adding an extra news with the same code when the lang is not "default" (/"en") > >- $new_lang = "default" if $new_lang eq 'en'; # Assume that "en" is "default" >+# $new_lang = "default" if $new_lang eq 'en'; # Assume that "en" is "default" > > my $sth_update = $dbh->prepare(q| > UPDATE additional_contents >@@ -124,7 +124,7 @@ return { > $dbh->do(q| > INSERT INTO additional_contents(category, code, location, branchcode, title, content, lang, published_on, updated_on, expirationdate, number, borrowernumber) > VALUES(?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?) >- |, undef, $category, 'tmp_code', $location, $c->{branchcode}, $c->{title}, $c->{content}, 'default', $c->{published_on}, $c->{updated_on}, $c->{expirationdate}, $c->{number}, $c->{borrowernumber}); >+ |, undef, $category, 'tmp_code', $location, $c->{branchcode}, $c->{title}, '', 'default', $c->{published_on}, $c->{updated_on}, $c->{expirationdate}, $c->{number}, $c->{borrowernumber}); > > $parent_idnew = $dbh->last_insert_id(undef, undef, 'additional_contents', undef); > } >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24387
:
122737
|
122738
|
122746
|
122748
|
122872
|
122873
|
122874
|
122878
|
122879
|
122880
|
123730
|
123731
|
123732
|
123733
|
123734
|
123795
|
123796
|
123797
|
123798
|
123803
|
123811
|
123854
|
123855
|
123856
|
124867
|
125545
|
142653