Bugzilla – Attachment 142730 Details for
Bug 27017
Add further defensive coding to EDI Invoice handling
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27017: (QA follow-up) Don't die if aqorders.biblionumber is null
Bug-27017-QA-follow-up-Dont-die-if-aqordersbiblion.patch (text/plain), 965 bytes, created by
Kyle M Hall
on 2022-10-27 18:03:28 UTC
(
hide
)
Description:
Bug 27017: (QA follow-up) Don't die if aqorders.biblionumber is null
Filename:
MIME Type:
Creator:
Kyle M Hall
Created:
2022-10-27 18:03:28 UTC
Size:
965 bytes
patch
obsolete
>From b38449373f28b86c4a8551eac2cf9ac02ad754b6 Mon Sep 17 00:00:00 2001 >From: Kyle Hall <kyle@bywatersolutions.com> >Date: Thu, 27 Oct 2022 14:03:05 -0400 >Subject: [PATCH] Bug 27017: (QA follow-up) Don't die if aqorders.biblionumber > is null > >--- > Koha/EDI.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/Koha/EDI.pm b/Koha/EDI.pm >index 9fc92a48d7..954d32e42b 100644 >--- a/Koha/EDI.pm >+++ b/Koha/EDI.pm >@@ -321,8 +321,8 @@ sub process_invoice { > $line->quantity ); > > my $order = $schema->resultset('Aqorder')->find($ordernumber); >- if ($order->biblionumber->biblionumber) { >- my $b = $order->biblionumber->biblionumber; >+ if (my $bib = $order->biblionumber) { >+ my $b = $bib->biblionumber; > my $id = $line->item_number_id; > $logger->trace("Updating bib:$b id:$id"); > } >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27017
:
113604
|
142714
|
142726
| 142730