Attachment 142978 Details for Bug 31877 – Bug 31877: Fix capitalization: "Delete this Tag" and "Repeat this Tag"

[patch] Bug 31877: Fix capitalization: "Delete this Tag" and "Repeat this Tag"

Bug-31877-Fix-capitalization-Delete-this-Tag-and-R.patch (text/plain), 6.31 KB, created by Martin Renvoize (ashimema) on 2022-11-02 14:04:55 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2022-11-02 14:04:55 UTC

Size: 6.31 KB

patch

obsolete

>From 67605485a8b87aa69a82e8ad062a6337a5aedae4 Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <katrin.fischer.83@web.de>
>Date: Mon, 24 Oct 2022 22:44:21 +0200
>Subject: [PATCH] Bug 31877: Fix capitalization: "Delete this Tag" and "Repeat
> this Tag"
>
>To get to the string in the staff interface:
>1. In the staff interface, go to Cataloging
>2. Click "New record"
>3. Hover the mouse cursor over one of the delete tag buttons (rectangle with a small x next to the tag title)
>   --> a little popup thing (tooltip?) appears with "Delete this Tag"
>4. Open the developper tools inspector in your browser
>5. Click on the delete tag button
>   --> the image alt text is "Delete this Tag"
>6. Repeat the same check in the authorities editor
>7. Apply patch
>8. All tooltips and alt text should read correctly now
>
>Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> .../prog/en/modules/authorities/authorities.tt            | 8 ++++----
> .../prog/en/modules/cataloguing/addbiblio.tt              | 8 ++++----
> 2 files changed, 8 insertions(+), 8 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt
>index 1b068ded6d..4a744bf144 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt
>@@ -465,12 +465,12 @@
>                                                     [% END %]
>                                                     <span class="field_controls">
>                                                         [% IF ( innerloo.repeatable ) %]
>-                                                            <a href="#" tabindex="1" class="buttonPlus" onclick="CloneField('tag_[% innerloo.tag | html %]_[% innerloo.index | html %][% innerloo.random | html %]','[% hide_marc | html %]','[% advancedMARCEditor | html %]'); return false;" title="Repeat this Tag">
>-                                                                <img src="[% interface | html %]/[% theme | html %]/img/repeat-tag.png" alt="Repeat this Tag" />
>+                                                            <a href="#" tabindex="1" class="buttonPlus" onclick="CloneField('tag_[% innerloo.tag | html %]_[% innerloo.index | html %][% innerloo.random | html %]','[% hide_marc | html %]','[% advancedMARCEditor | html %]'); return false;" title="Repeat this tag">
>+                                                                <img src="[% interface | html %]/[% theme | html %]/img/repeat-tag.png" alt="Repeat this tag" />
>                                                             </a>
>                                                         [% END %]
>-                                                        <a href="#" tabindex="1" class="buttonMinus" onclick="UnCloneField('tag_[% innerloo.tag | html %]_[% innerloo.index | html %][% innerloo.random | html %]'); return false;" title="Delete this Tag">
>-                                                            <img src="[% interface | html %]/[% theme | html %]/img/delete-tag.png" alt="Delete this Tag" />
>+                                                        <a href="#" tabindex="1" class="buttonMinus" onclick="UnCloneField('tag_[% innerloo.tag | html %]_[% innerloo.index | html %][% innerloo.random | html %]'); return false;" title="Delete this tag">
>+                                                            <img src="[% interface | html %]/[% theme | html %]/img/delete-tag.png" alt="Delete this tag" />
>                                                         </a>
>                                                     </span> 
>                                                 </div> 
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
>index f16f5c8147..5ec7a309d1 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
>@@ -1084,12 +1084,12 @@ function PopupMARCFieldDoc(field) {
> 
>                                                 <span class="field_controls">
>                                                     [% IF ( innerloo.repeatable ) %]
>-                                                        <a href="#" tabindex="1" class="buttonPlus" onclick="CloneField('tag_[% innerloo.tag | html %]_[% innerloo.index | html %][% innerloo.random | html %]','0','[% advancedMARCEditor | html %]'); return false;" title="Repeat this Tag">
>-                                                            <img src="[% interface | html %]/[% theme | html %]/img/repeat-tag.png" alt="Repeat this Tag" />
>+                                                        <a href="#" tabindex="1" class="buttonPlus" onclick="CloneField('tag_[% innerloo.tag | html %]_[% innerloo.index | html %][% innerloo.random | html %]','0','[% advancedMARCEditor | html %]'); return false;" title="Repeat this tag">
>+                                                            <img src="[% interface | html %]/[% theme | html %]/img/repeat-tag.png" alt="Repeat this tag" />
>                                                         </a>
>                                                     [% END %]
>-                                                    <a href="#" tabindex="1" class="buttonMinus" onclick="UnCloneField('tag_[% innerloo.tag | html %]_[% innerloo.index | html %][% innerloo.random | html %]'); return false;" title="Delete this Tag">
>-                                                        <img src="[% interface | html %]/[% theme | html %]/img/delete-tag.png" alt="Delete this Tag" />
>+                                                    <a href="#" tabindex="1" class="buttonMinus" onclick="UnCloneField('tag_[% innerloo.tag | html %]_[% innerloo.index | html %][% innerloo.random | html %]'); return false;" title="Delete this tag">
>+                                                        <img src="[% interface | html %]/[% theme | html %]/img/delete-tag.png" alt="Delete this tag" />
>                                                     </a>
>                                                 </span> 
>                                             </div> 
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 31877: 142569 | 142572 | 142978