From bfa26a12134dececdecdf3439698b0b25e7e92a8 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Fri, 4 Nov 2022 11:42:47 +0000 Subject: [PATCH] Bug 32109: Fix spacing in toolbars containing text links This patch adds a new class to toolbars in certain contexts: Where the toolbar contains only text links (as opposed to Bootstrap-styled controls). This lets us set some comfortable padding on the links. To test, apply the patch and rebuild the staff interface CSS. Test the following pages to confirm that the toolbar of selection links ("Select all," "Clear all," etc.) has legible spacing. - Cataloging -> Batch item modification -> List of submitted barcodes - Cataloging -> Batch item deletion -> List of submitted barcodes - Cataloging -> Batch record modification -> List of submitted records - Cataloging -> Batch record deletion -> List of submitted records - Tools -> Batch extend due dates -> Preview results - Tools -> Batch patron modification -> List of submitted patrons --- koha-tmpl/intranet-tmpl/prog/css/src/_toolbar.scss | 7 +++++++ koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc | 2 +- .../prog/en/modules/tools/batch_delete_records.tt | 4 ++-- .../prog/en/modules/tools/batch_extend_due_dates.tt | 2 +- .../prog/en/modules/tools/batch_record_modification.tt | 4 ++-- .../intranet-tmpl/prog/en/modules/tools/modborrowers.tt | 2 +- 6 files changed, 14 insertions(+), 7 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/_toolbar.scss b/koha-tmpl/intranet-tmpl/prog/css/src/_toolbar.scss index e18ff3dce1..75094af8e0 100644 --- a/koha-tmpl/intranet-tmpl/prog/css/src/_toolbar.scss +++ b/koha-tmpl/intranet-tmpl/prog/css/src/_toolbar.scss @@ -75,4 +75,11 @@ font-size: 100%; } } + + &.selections-toolbar { + a { + display: inline-block; + padding: 0 .5em; + } + } } diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc index 237500bf7a..ae9cdcf6e8 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc @@ -212,7 +212,7 @@ [% IF display_columns_selection %][%# Needs js/pages/batchMod.js %] [% IF checkboxes_edit OR checkboxes_delete %] -
+ [% END %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt index 845b3e90df..6960819092 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt @@ -138,7 +138,7 @@ [% ELSIF op == 'list' %] [% IF records %] [% IF recordtype == 'biblio' %] -
+
Select all | Clear all | Select without items @@ -174,7 +174,7 @@
Reminder: this action will delete all selected bibliographic records, attached subscriptions, existing holds, and attached items!
[% ELSE %] -
+
Select all | Clear all | Clear used authorities diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_extend_due_dates.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_extend_due_dates.tt index c0b9682ef8..8e6629dceb 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_extend_due_dates.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_extend_due_dates.tt @@ -127,7 +127,7 @@ [% ELSIF view == 'list' %] [% IF checkouts.count %]
-
+ diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt index 1a0344371e..0e2782a0d6 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt @@ -188,7 +188,7 @@
[% IF recordtype == 'biblio' %] -
+ @@ -216,7 +216,7 @@
Reminder: this action will modify all selected biblios!
[% ELSE %] -
+ diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt index 2200c9d52e..c3a50a1952 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt @@ -201,7 +201,7 @@ [% IF ( borrowers ) %] - + [% END %] [% END %] [% IF borrowers %] -- 2.20.1