Bugzilla – Attachment 143366 Details for
Bug 32119
Cannot add new guarantee
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32119: (bug 31422 follow-up) Fix add guarantee
Bug-32119-bug-31422-follow-up-Fix-add-guarantee.patch (text/plain), 1.28 KB, created by
Jonathan Druart
on 2022-11-07 12:50:45 UTC
(
hide
)
Description:
Bug 32119: (bug 31422 follow-up) Fix add guarantee
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2022-11-07 12:50:45 UTC
Size:
1.28 KB
patch
obsolete
>From edf4ef57ac3f25c030e6c4fc48492dc25938d19d Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Mon, 7 Nov 2022 12:38:33 +0000 >Subject: [PATCH] Bug 32119: (bug 31422 follow-up) Fix add guarantee > >To test: >1 - go to a patron detail view, click "add guarantee" >2 - Confirm form loads >3 - Confirm categories lsited are eligible to have a guarantor >4 - Fill out required fields and confirm patron saved correctly > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > members/memberentry.pl | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/members/memberentry.pl b/members/memberentry.pl >index ca43a1eedec..2ebf3b43359 100755 >--- a/members/memberentry.pl >+++ b/members/memberentry.pl >@@ -659,7 +659,8 @@ my $patron_categories = Koha::Patron::Categories->search_with_library_limits( > my $no_categories = ! $patron_categories->count; > my $categories = {}; > my @patron_categories = $patron_categories->as_list; >-unless ( $patron_categories->find( $category->id ) ){ >+# When adding a guarantor we don't have a category yet, and only want to choose from the eligible categories >+unless ( !$category || $patron_categories->find( $category->id ) ){ > $template->param( limited_category => 1 ); > push @patron_categories, $category; > } >-- >2.25.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32119
:
143351
|
143352
|
143364
|
143366
|
143371