Bugzilla – Attachment 14340 Details for
Bug 8883
opacsmallimage doesn't work in ccsr theme
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 8883: 'opacsmallimage' doesn't work in ccsr theme
SIGNED-OFF-Bug-8883-opacsmallimage-doesnt-work-in-.patch (text/plain), 1.98 KB, created by
Owen Leonard
on 2012-12-31 15:15:38 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 8883: 'opacsmallimage' doesn't work in ccsr theme
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2012-12-31 15:15:38 UTC
Size:
1.98 KB
patch
obsolete
>From 17771f831adcd2715c07d8dcfbc279293330b208 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Mon, 31 Dec 2012 13:07:02 +0000 >Subject: [PATCH] [SIGNED-OFF] Bug 8883: 'opacsmallimage' doesn't work in ccsr > theme >Content-Type: text/plain; charset="utf-8" > >This patch makes it possible to customize the CCSR theme using the >opacsmallimage system preference. It also enables the LibraryName >preference for opacsmallimage alt text. > >To test, set the opacsmallimage preference and switch to the CCSR >theme. Your custom image should appear. Set the LibraryName preference >and confirm that the alt attribute of the custom logo changes >accordingly. > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> > >This patch works correctly, although it lacked a description and test >plan, which I have added. I would have used IF instead of UNLESS because >to me that seems more readable, but it's not a deal-breaker. > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > koha-tmpl/opac-tmpl/ccsr/en/includes/masthead.inc | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > >diff --git a/koha-tmpl/opac-tmpl/ccsr/en/includes/masthead.inc b/koha-tmpl/opac-tmpl/ccsr/en/includes/masthead.inc >index d666113..b1bfb29 100644 >--- a/koha-tmpl/opac-tmpl/ccsr/en/includes/masthead.inc >+++ b/koha-tmpl/opac-tmpl/ccsr/en/includes/masthead.inc >@@ -77,7 +77,19 @@ > <div id="opac-main-search" class="yui-g"> > > <a class="logo" href="/cgi-bin/koha/opac-main.pl"> >+ [% UNLESS ( opacsmallimage ) %] >+ [% UNLESS ( LibraryName ) %] > <img src="/opac-tmpl/ccsr/images/logo-koha.png" alt="Koha Online Catalog" /> >+ [% ELSE %] >+ <img src="/opac-tmpl/ccsr/images/logo-koha.png" alt="[% LibraryName %] Online Catalog" /> >+ [% END %] >+ [% ELSE %] >+ [% UNLESS ( LibraryName ) %] >+ <img src="[% opacsmallimage %]" alt="Koha Online Catalog" /> >+ [% ELSE %] >+ <img src="[% opacsmallimage %]" alt="[% LibraryName %] Online Catalog" /> >+ [% END %] >+ [% END %] > </a> > > <div id="fluid"> >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8883
:
14334
|
14340
|
14599