Bugzilla – Attachment 143790 Details for
Bug 32151
[WARN] Use of uninitialized value in numeric ne (!=) at C4/Ris.pm line 834.
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32151: Resolve uninitialized warn in numeric ne in C4::Ris
Bug-32151-Resolve-uninitialized-warn-in-numeric-ne.patch (text/plain), 1.10 KB, created by
Jonathan Druart
on 2022-11-11 14:20:56 UTC
(
hide
)
Description:
Bug 32151: Resolve uninitialized warn in numeric ne in C4::Ris
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2022-11-11 14:20:56 UTC
Size:
1.10 KB
patch
obsolete
>From 01a3ac71a677aef34d3e0ee2c928815ce1b53e3f Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Wed, 9 Nov 2022 15:12:31 +0000 >Subject: [PATCH] Bug 32151: Resolve uninitialized warn in numeric ne in > C4::Ris > >We should not write: > if ($kwfield != undef) { > >Test plan: >Pick record with UTF8 chars. >Download via cart or shelf in RIS format. >Check your logs. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > C4/Ris.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Ris.pm b/C4/Ris.pm >index 9ab50d924b3..6585ac4239a 100644 >--- a/C4/Ris.pm >+++ b/C4/Ris.pm >@@ -831,7 +831,7 @@ sub get_keywords { > > ## loop over all 6XX fields > foreach my $kwfield (@keywords) { >- if ($kwfield != undef) { >+ if( defined $kwfield ) { > ## authornames get special treatment > if ($fieldname eq "600") { > my $val = normalize_author($kwfield->subfield('a'), $kwfield->subfield('b'), $kwfield->subfield('c'), $kwfield->indicator('1')); >-- >2.25.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32151
:
143519
| 143790