Bugzilla – Attachment 143895 Details for
Bug 32187
(Bug 24161 follow-up) With IndependentBranches on a non superlibrarian librarian is not able to track late orders
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32187: Correct join on borrowers in Koha::Acq::Orders->filter_by_late
Bug-32187-Correct-join-on-borrowers-in-KohaAcqOrde.patch (text/plain), 1.49 KB, created by
Jonathan Druart
on 2022-11-15 09:10:19 UTC
(
hide
)
Description:
Bug 32187: Correct join on borrowers in Koha::Acq::Orders->filter_by_late
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2022-11-15 09:10:19 UTC
Size:
1.49 KB
patch
obsolete
>From f8a7ed16f579b4c1fc6661eb7187daa35856f44b Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 15 Nov 2022 10:08:46 +0100 >Subject: [PATCH] Bug 32187: Correct join on borrowers in > Koha::Acq::Orders->filter_by_late > >--- > Koha/Acquisition/Orders.pm | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > >diff --git a/Koha/Acquisition/Orders.pm b/Koha/Acquisition/Orders.pm >index e429475dc3e..0d85dfd7672 100644 >--- a/Koha/Acquisition/Orders.pm >+++ b/Koha/Acquisition/Orders.pm >@@ -128,7 +128,7 @@ sub filter_by_lates { > ( > C4::Context->preference('IndependentBranches') > && !C4::Context->IsSuperLibrarian >- ? ( 'borrower.branchcode' => C4::Context->userenv->{branch} ) >+ ? ( 'authorisedby.branchcode' => C4::Context->userenv->{branch} ) > : () > ), > >@@ -142,7 +142,14 @@ sub filter_by_lates { > '+as' => [qw/ > calculated_estimated_delivery_date > /], >- join => { 'basketno' => 'booksellerid' }, >+ join => ( >+ ( >+ C4::Context->preference('IndependentBranches') >+ && !C4::Context->IsSuperLibrarian >+ ) >+ ? { 'basketno' => [ 'authorisedby', 'booksellerid' ] } >+ : { 'basketno' => 'booksellerid' } >+ ), > prefetch => {'basketno' => 'booksellerid'}, > } > ); >-- >2.25.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32187
:
143894
| 143895