From 8aae962d58f10e0d30923052b24dc1b574ec560b Mon Sep 17 00:00:00 2001 From: Emmi Takkinen Date: Wed, 16 Nov 2022 09:26:46 +0200 Subject: [PATCH] Bug 16223: Add correct value attributes to restriction options in select element Restrictions weren't lift after payment because value attributes for restrictions code were missing from restriction select element in patron-restrictions-tab.inc. Due this restrictions were always set as type "MANUAL". To test: 1. Add new restriction which has "Lift after payment?" set as Yes and fee limit as 5. 2. Create fees for a patron so they exceed fee limit e.g. 10 3. Add restriction made in step 1. for the patron 4. Pay patrons fees partially so that they go under fee limit => Note that patrons restriction should now be lifted. Also prove t/db_dependent/Patron/Borrower_Debarments.t. Sponsored-by: Koha-Suomi Oy --- .../prog/en/includes/patron-restrictions-tab.inc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-restrictions-tab.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-restrictions-tab.inc index 4bedce39d1..1242dbf746 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-restrictions-tab.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-restrictions-tab.inc @@ -59,9 +59,9 @@ [% FOREACH restriction_type IN restriction_types %] [% IF !restriction_type.is_system %] [% IF restriction_type.is_default %] - + [% ELSE %] - + [% END %] [% END %] [% END %] -- 2.34.1