Bugzilla – Attachment 144013 Details for
Bug 32248
t/00-checkdatabase-version.t should be removed
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32248: Remove t/00-checkdatabase-version.t
Bug-32248-Remove-t00-checkdatabase-versiont.patch (text/plain), 2.64 KB, created by
Katrin Fischer
on 2022-11-17 16:55:04 UTC
(
hide
)
Description:
Bug 32248: Remove t/00-checkdatabase-version.t
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2022-11-17 16:55:04 UTC
Size:
2.64 KB
patch
obsolete
>From b14ac79619160c76951d32e280ada686cd55424e Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 17 Nov 2022 14:52:25 +0100 >Subject: [PATCH] Bug 32248: Remove t/00-checkdatabase-version.t > >Since bug 25078 we do no longer use updatedatabase.pl. This test was >there to make sure the RM(aints) was replacing the XXX correctly. > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > t/00-checkdatabase-version.t | 60 ------------------------------------ > 1 file changed, 60 deletions(-) > delete mode 100755 t/00-checkdatabase-version.t > >diff --git a/t/00-checkdatabase-version.t b/t/00-checkdatabase-version.t >deleted file mode 100755 >index 9e94cbe50f..0000000000 >--- a/t/00-checkdatabase-version.t >+++ /dev/null >@@ -1,60 +0,0 @@ >-# Copyright 2010 Chris Cormack >-# >-# This file is part of Koha. >-# >-# Koha is free software; you can redistribute it and/or modify it >-# under the terms of the GNU General Public License as published by >-# the Free Software Foundation; either version 3 of the License, or >-# (at your option) any later version. >-# >-# Koha is distributed in the hope that it will be useful, but >-# WITHOUT ANY WARRANTY; without even the implied warranty of >-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >-# GNU General Public License for more details. >-# >-# You should have received a copy of the GNU General Public License >-# along with Koha; if not, see <http://www.gnu.org/licenses>. >- >-use strict; >-use warnings; >- >-use Test::More; >-use File::Spec; >-use File::Find; >-use IO::File; >- >-my @files =('kohaversion.pl','installer/data/mysql/updatedatabase.pl'); >- >-foreach my $file (@files){ >- next unless -f $file; >- my @name_parts = File::Spec->splitpath($file); >- my %dirs = map { $_ => 1 } File::Spec->splitdir($name_parts[1]); >- next if exists $dirs{'.git'}; >- >- my $fh = IO::File->new($file, 'r'); >- my $xxx_found = 0; >- my $line = 0; >- while (<$fh>) { >- $line++; >- if (/XXX/i) { >- #two lines are an exception for updatedatabase (routine SetVersion and TransferToNum) >- next >- if $file =~ /updatedatabase/ >- && ( /s\/XXX\$\/999\/;/ >- || /\$_\[0\]=~ \/XXX\$\/;/ >- || /version contains XXX/ >- || /\$proposed_version =~ m\/XXX\// ); >- $xxx_found = 1; >- last; >- } >- } >- close $fh; >- if ($xxx_found) { >- fail("$file has no XXX in it"); >- diag("XXX found in line $line"); >- } else { >- pass("$file has no XXX in it"); >- } >-} >- >-done_testing(); >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32248
:
144000
|
144012
| 144013