From f58aec294d27df48bb6bbd9ba16df5ada8deed8e Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Wed, 16 May 2012 08:01:06 -0400 Subject: [PATCH] [SIGNED-OFF] Bug 9336 - Don't let un-holdable records block bulk holds Content-Type: text/plain; charset="utf-8" If one or more records selected for a multi-hold have no items, the multi-holds process will prevent the librarian from completing the multi-hold. This forces the librarian to go back and remove the records with no items from the multi-hold. It would be better to warn the librarian that some of the records won't be held instead, that way, the librarian does not need to go to the trouble of removing the non-holdable records from the multi-hold to complete the process. Fixed by not disabling the submit button in the event that one of the records has no holdable items. Updated text of submit buttons. Test plan: 1) Apply patch for Bug 7703 2) Apply this patch 3) Place a multi-hold on two records, where one has hold-able items, and the other does not have any hold-able items. 4) Instead of being unable to submit the hold request, you should now be able to. Signed-off-by: Owen Leonard Copied test plan from bug report in order to fulfill commit message requirements. --- .../prog/en/modules/reserve/request.tt | 6 +++--- reserve/request.pl | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt index 05470eb..c93e5b7 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt @@ -504,11 +504,11 @@ function checkMultiHold() {
[% IF ( borrowernumber ) %] [% IF ( override_required ) %] - + [% ELSIF ( none_available ) %] - + [% ELSE %] - + [% END %] [% END %]
diff --git a/reserve/request.pl b/reserve/request.pl index 705f4f6..9a4fcbd 100755 --- a/reserve/request.pl +++ b/reserve/request.pl @@ -475,7 +475,7 @@ foreach my $biblionumber (@biblionumbers) { } elsif ( C4::Context->preference('AllowHoldPolicyOverride') ) { -# If AllowHoldPolicyOverride is set, it should override EVERY restriction, not just branch item rules + # If AllowHoldPolicyOverride is set, it should override EVERY restriction, not just branch item rules $item->{override} = 1; $num_override++; } -- 1.7.9.5