Bugzilla – Attachment 144360 Details for
Bug 32351
Fix all TestBuilder calls failing due to wrong column names
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32351: Fix CourseItems.t
Bug-32351-Fix-CourseItemst.patch (text/plain), 3.05 KB, created by
Tomás Cohen Arazi
on 2022-11-30 18:58:01 UTC
(
hide
)
Description:
Bug 32351: Fix CourseItems.t
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi
Created:
2022-11-30 18:58:01 UTC
Size:
3.05 KB
patch
obsolete
>From 2a0696c81d8540cf8eecdf31c7c19bf81dd600fa Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Wed, 30 Nov 2022 15:41:59 -0300 >Subject: [PATCH] Bug 32351: Fix CourseItems.t > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > t/db_dependent/CourseReserves/CourseItems.t | 25 ++++----------------- > 1 file changed, 4 insertions(+), 21 deletions(-) > >diff --git a/t/db_dependent/CourseReserves/CourseItems.t b/t/db_dependent/CourseReserves/CourseItems.t >index 9cb287cd327..6e419cdb256 100755 >--- a/t/db_dependent/CourseReserves/CourseItems.t >+++ b/t/db_dependent/CourseReserves/CourseItems.t >@@ -55,7 +55,6 @@ my $course = $builder->build({ > source => 'CourseReserve', > value => { > ci_id => $ci_id, >- enabled => 'no', > } > }); > >@@ -219,7 +218,6 @@ subtest 'Ensure modifying fields on existing course items updates the item and c > source => 'CourseReserve', > value => { > ci_id => $ci_id, >- enabled => 'no', > } > }); > >@@ -336,12 +334,7 @@ subtest 'Ensure modifying fields on existing course items updates the item and c > subtest 'Ensure item info is preserved' => sub { > plan tests => 8; > >- my $course = $builder->build({ >- source => 'Course', >- value => { >- enabled => 'no', >- } >- }); >+ my $course = $builder->build({ source => 'Course' }); > my $item = $builder->build_sample_item({ ccode=>"grasshopper", location=>"transylvania"}); > #Add course item but change nothing > my $course_item_id = ModCourseItem( >@@ -366,12 +359,7 @@ subtest 'Ensure item info is preserved' => sub { > is( $item->holdingbranch, $item_after->holdingbranch, "Holdingbranch is unchanged after adding to and removing from course reserves for inactive course"); > is( $item->ccode, $item_after->ccode, "Collection is unchanged after adding to and removing from course reserves for inactive course"); > >- $course = $builder->build({ >- source => 'Course', >- value => { >- enabled => 'yes', >- } >- }); >+ $course = $builder->build({ source => 'Course' }); > $item = $builder->build_sample_item({ ccode=>"grasshopper", location=>"transylvania"}); > #Add course item but change nothing > $course_item_id = ModCourseItem( >@@ -401,12 +389,7 @@ subtest 'Ensure item info is preserved' => sub { > subtest 'biblio added to course without items' => sub { > plan tests => 1; > >- my $course = $builder->build({ >- source => 'Course', >- value => { >- enabled => 'no', >- } >- }); >+ my $course = $builder->build({ source => 'Course' }); > #Add course item but change nothing > my $course_item_id = ModCourseItem( > itemnumber => undef, >@@ -424,7 +407,7 @@ subtest 'biblio added to course without items' => sub { > public_note => '', > ); > >- my $course_item = GetCourseItem({ ci_id => $course_item_id }); >+ my $course_item = GetCourseItem( ci_id => $course_item_id ); > is( $course_item->{itemnumber}, undef, "Course reserve with no item correctly added" ); > }; > >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32351
:
144236
|
144240
|
144243
|
144244
|
144249
|
144250
|
144251
|
144252
|
144353
|
144354
|
144355
|
144356
|
144357
|
144358
|
144359
| 144360 |
144361
|
144362
|
144363
|
144364
|
144365