From 52ff71e7bce3622b025b5230cd58d9e2e64d11e2 Mon Sep 17 00:00:00 2001 From: Matt Blenkinsop Date: Thu, 24 Nov 2022 15:37:51 +0000 Subject: [PATCH] Bug 31160: Required fields in patron api Content-Type: text/plain; charset=utf-8 The Patron API PUT request required the fields "surname","address","city","library_id","category_id". Meanwhile the CSV import page for patrons only requires "surname","library_id","category_id". The fields for "address" and "city" have been removed from the "required" section of the api>v1>swagger>definitions>patron.yaml file to match the CSV import page. Test Plan: 1) Send a PUT request to http://localhost:8081/api/v1/patrons/19 with an empty body 2) Error message should ask for 5 missing fields as listed above 3) Apply patch 4) Restart Apache server using "restart_all" in your ktd shell 5) Resubmit your request 6) Error message should now only request "surname","library_id","category_id" Signed-off-by: David Nind Signed-off-by: Marcel de Rooy --- api/v1/swagger/definitions/patron.yaml | 2 -- 1 file changed, 2 deletions(-) diff --git a/api/v1/swagger/definitions/patron.yaml b/api/v1/swagger/definitions/patron.yaml index b5142dba06..7967722db7 100644 --- a/api/v1/swagger/definitions/patron.yaml +++ b/api/v1/swagger/definitions/patron.yaml @@ -377,7 +377,5 @@ properties: additionalProperties: false required: - surname - - address - - city - library_id - category_id -- 2.30.2