Bugzilla – Attachment 144767 Details for
Bug 32504
Empty column name, misaligning visibility, and export for basket/orders in table settings
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32504: Fix misalignment of visibility of basket orders table columns and missing export columns
Bug-32504-Fix-misalignment-of-visibility-of-basket.patch (text/plain), 3.20 KB, created by
Slava Shishkin
on 2022-12-21 12:47:56 UTC
(
hide
)
Description:
Bug 32504: Fix misalignment of visibility of basket orders table columns and missing export columns
Filename:
MIME Type:
Creator:
Slava Shishkin
Created:
2022-12-21 12:47:56 UTC
Size:
3.20 KB
patch
obsolete
>From 884e1f5d5e966c79eb1025d3122597ddd45d30ed Mon Sep 17 00:00:00 2001 >From: Slava Shishkin <slavashishkin@gmail.com> >Date: Wed, 21 Dec 2022 14:46:45 +0200 >Subject: [PATCH] Bug 32504: Fix misalignment of visibility of basket orders > table columns and missing export columns > >To reproduce: >1. Go to /cgi-bin/koha/admin/columns_settings.pl >2. In the section Acquisition > Basket > Orders uncheck all checkboxes in the table settings >3. Go to a separate browser window to /cgi-bin/koha/acqui/booksellers.pl and open/create a new basket and add one book to it so the basket table will have rows in the "Order" table which we will configure below: >4. Click on the ["Columns" settings] for the table. >5. In the dropdown menu, observe that all Columns are marked as visible and correspond to the current table display. >6. Also check the export table feature: Click on "Export" and choose print, you will see that Columns up to GST (goods_and_services_tax) are displayed, and Fund and Estimated delivery date are missing. >7. Go back to table settings (like it was in steps.1-2) >8. Make the estimated_delivery_date column 'invisible by default' by checking out the appropriate checkbox and saving the changes. >9. Refresh the basket window/page (like in step 3). >10. Observe that in the table the whole columns "Estimated delivery date" is visible but "Fund" is gone. >11. Click on the ["Columns" settings] for the table. >12. In the dropdown menu observe that the wrong column is disabled ("Fund" instead of "Estimated delivery date"). >13. Apply the patch. >14. Go through steps 3-12 and make sure that everything mentioned in those steps now works correctly: when you hide any columns in columns_settings.pl they are correctly hidden for the "Order" table, as well when exporting the table, the Fund, and Estimated delivery date columns are now exported. > >Note: this patch also respects Koha.Preference('EDIFACT') setting and when it's enabled it also correctly hides/shows and exports the 'supplier_report' column. >--- > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt >index 35b35af7ab..acdb1cb343 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt >@@ -1024,12 +1024,12 @@ > $(document).ready(function() { > var table_settings = [% TablesSettings.GetTableSettings( 'acqui', 'basket', 'orders', 'json' ) | $raw %]; > [% IF !(Koha.Preference('EDIFACT') && ediaccount) %] >- table_settings['columns'].splice(13, 1); >+ table_settings['columns'].splice(16, 1); > [% END %] > KohaTable("orders", { > "sPaginationType": "full", > "autoWidth": false, >- "exportColumns": [0,1,2,3,4,5,6,7,8,9,10,11,12,13], >+ "exportColumns": [0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15[% IF (Koha.Preference('EDIFACT') && ediaccount) %],16[% END %]], > }, table_settings); > > var cancelledorderst = $("#cancelledorderst").dataTable($.extend(true, {}, dataTablesDefaults, { >-- >2.38.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32504
:
144739
|
144767
|
145827
|
145828