From a35d94ace62fa1b85b801bb4a0cbf746b1b8323e Mon Sep 17 00:00:00 2001
From: Kyle M Hall <kyle@bywatersolutions.com>
Date: Fri, 14 Dec 2012 14:40:14 -0500
Subject: [PATCH] Bug 9292 - Remove dead code related to 'publictype'
This patch removes the superflous code related to 'publictype' which
is a key set for item hashes in some perl files. This key is never
used or stored.
Test Plan:
1) Apply patch
2) Test catalogue/detail.pl, opac/opac-detail.pl and opac/opac-user.pl
3) You should not see any changes in behavior
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
---
catalogue/detail.pl | 4 ----
opac/opac-detail.pl | 5 -----
opac/opac-user.pl | 7 -------
3 files changed, 0 insertions(+), 16 deletions(-)
diff --git a/catalogue/detail.pl b/catalogue/detail.pl
index 9379704..6b313b2 100755
--- a/catalogue/detail.pl
+++ b/catalogue/detail.pl
@@ -197,10 +197,6 @@ foreach my $item (@items) {
# can place holds defaults to yes
$norequests = 0 unless ( ( $item->{'notforloan'} > 0 ) || ( $item->{'itemnotforloan'} > 0 ) );
- # format some item fields for display
- if ( defined $item->{'publictype'} ) {
- $item->{ $item->{'publictype'} } = 1;
- }
$item->{imageurl} = defined $item->{itype} ? getitemtypeimagelocation('intranet', $itemtypes->{ $item->{itype} }{imageurl})
: '';
diff --git a/opac/opac-detail.pl b/opac/opac-detail.pl
index 22c922b..8970090 100755
--- a/opac/opac-detail.pl
+++ b/opac/opac-detail.pl
@@ -529,11 +529,6 @@ for my $itm (@items) {
&& (not $itemtypes->{$itm->{'itype'}}->{notforloan} )
&& ($itm->{'itemnumber'} ) );
- if ( defined $itm->{'publictype'} ) {
- # I can't actually find any case in which this is defined. --amoore 2008-12-09
- $itm->{ $itm->{'publictype'} } = 1;
- }
-
# get collection code description, too
my $ccode = $itm->{'ccode'};
$itm->{'ccode'} = $collections->{$ccode} if ( defined($collections) && exists( $collections->{$ccode} ) );
diff --git a/opac/opac-user.pl b/opac/opac-user.pl
index 1c942d5..229104d 100755
--- a/opac/opac-user.pl
+++ b/opac/opac-user.pl
@@ -173,11 +173,6 @@ if ($issues){
}
$issue->{'charges'} = $charges;
- # get publictype for icon
-
- my $publictype = $issue->{'publictype'};
- $issue->{$publictype} = 1;
-
# check if item is renewable
my ($status,$renewerror) = CanBookBeRenewed( $borrowernumber, $issue->{'itemnumber'} );
($issue->{'renewcount'},$issue->{'renewsallowed'},$issue->{'renewsleft'}) = GetRenewCount($borrowernumber, $issue->{'itemnumber'});
@@ -258,8 +253,6 @@ foreach my $res (@reserves) {
$res->{'expirationdate'} = '';
}
- my $publictype = $res->{'publictype'};
- $res->{$publictype} = 1;
$res->{'waiting'} = 1 if $res->{'found'} eq 'W';
$res->{'branch'} = $branches->{ $res->{'branchcode'} }->{'branchname'};
my $biblioData = GetBiblioData($res->{'biblionumber'});
--
1.7.2.5